Page MenuHomeFreeBSD

geom_vfs: Pre-allocate event for g_vfs_destroy.
ClosedPublic

Authored by jhb on Jul 29 2021, 11:13 PM.

Details

Summary

When an active g_vfs is orphaned due to an underlying disk going away
the destroy is deferred until the filesystem is unmounted in
g_vfs_done(). However, g_vfs_done() is invoked from a non-sleepable
context and cannot use M_WAITOK to allocate the event. Instead,
allocate the event in g_vfs_orphan() and save it in the softc to be
retrieved by the last call to g_vfs_done().

Reported by: Jithesh Arakkan @ Chelsio
Sponsored by: Chelsio Communications

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Jul 29 2021, 11:13 PM
jhb created this revision.

Looks good. I think this covers the different cases.

This revision is now accepted and ready to land.Jul 30 2021, 12:05 AM