Page MenuHomeFreeBSD

geom_vfs: Pre-allocate event for g_vfs_destroy.
ClosedPublic

Authored by jhb on Jul 29 2021, 11:13 PM.
Tags
None
Referenced Files
F170707699: D31354.id92972.diff
Sun, Sep 6, 3:27 AM
F170706517: D31354.id92972.diff
Sun, Sep 6, 3:19 AM
Unknown Object (File)
Sat, Sep 5, 4:35 PM
Unknown Object (File)
Thu, Sep 3, 7:23 AM
Unknown Object (File)
Thu, Sep 3, 3:04 AM
Unknown Object (File)
Tue, Sep 1, 3:06 AM
Unknown Object (File)
Sun, Aug 30, 3:03 AM
Unknown Object (File)
Sun, Aug 30, 2:36 AM
Subscribers
None

Details

Summary

When an active g_vfs is orphaned due to an underlying disk going away
the destroy is deferred until the filesystem is unmounted in
g_vfs_done(). However, g_vfs_done() is invoked from a non-sleepable
context and cannot use M_WAITOK to allocate the event. Instead,
allocate the event in g_vfs_orphan() and save it in the softc to be
retrieved by the last call to g_vfs_done().

Reported by: Jithesh Arakkan @ Chelsio
Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jul 29 2021, 11:13 PM
jhb created this revision.

Looks good. I think this covers the different cases.

This revision is now accepted and ready to land.Jul 30 2021, 12:05 AM
This revision was automatically updated to reflect the committed changes.