Page MenuHomeFreeBSD
Differential D31199

awk: revert upstream's attempt to disallow hex strings
ClosedPublic
Actions

Authored by imp on Jul 15 2021, 10:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 1:25 AM
Unknown Object (File)
Fri, Apr 5, 2:50 PM
Unknown Object (File)
Mar 12 2024, 10:15 PM
Unknown Object (File)
Mar 12 2024, 10:15 PM
Unknown Object (File)
Mar 12 2024, 10:15 PM
Unknown Object (File)
Mar 9 2024, 3:40 AM
Unknown Object (File)
Mar 9 2024, 3:40 AM
Unknown Object (File)
Mar 7 2024, 9:33 PM
View All 24 Files
Subscribers
None

Details

Reviewers
kevans
Commits
rG770e04e65fbb: awk: revert upstream's attempt to disallow hex strings
rG3e8044635219: awk: revert upstream's attempt to disallow hex strings
rG40a925385fa6: awk: revert upstream's attempt to disallow hex strings
rGd4d252c49976: awk: revert upstream's attempt to disallow hex strings
Summary

Upstream one-true-awk decided to disallow hex strings as numbers. This
is in line with awk's behavior prior to C99, and allowed by the POSIX
standard. The standard, however, allows them to be treated as numbers
because that's what the standard said in the 2001 through 2004 editions.
Since 2001, the nawk in FreeBSD has treated them as numbers, so restore
that behavior, allowed by the standard.

A number of scripts in the FreeBSD tree depend on this interpretation,
including scripts to build the kernel which had mysteriously started
failing for some people and not others. By re-allowing 0x hex numbers,
this fixes those scripts and restores POLA.

Upstream issue: https://github.com/onetrueawk/awk/issues/126
Sponsored by: Netflix
MFC After: ASAP

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jul 15 2021, 10:52 PM
imp created this revision.
Harbormaster completed remote builds in B40494: Diff 92254.Jul 15 2021, 10:52 PM
imp updated this revision to Diff 92255.Jul 15 2021, 10:56 PM

This test makes more sense.

Harbormaster completed remote builds in B40495: Diff 92255.Jul 15 2021, 10:56 PM
imp edited the summary of this revision. (Show Details)Jul 15 2021, 10:57 PM
imp added a reviewer: kevans.
imp updated this revision to Diff 92256.Jul 15 2021, 10:59 PM

more typos

Harbormaster completed remote builds in B40496: Diff 92256.Jul 15 2021, 10:59 PM
kevans accepted this revision.Jul 15 2021, 10:59 PM
kevans added inline comments.
contrib/one-true-awk/lib.c
801

prior

This revision is now accepted and ready to land.Jul 15 2021, 10:59 PM
Closed by commit rGd4d252c49976: awk: revert upstream's attempt to disallow hex strings (authored by imp). · Explain WhyJul 15 2021, 11:09 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGd4d252c49976: awk: revert upstream's attempt to disallow hex strings.
imp added a commit: rG40a925385fa6: awk: revert upstream's attempt to disallow hex strings.Jul 15 2021, 11:28 PM
imp added a commit: rG3e8044635219: awk: revert upstream's attempt to disallow hex strings.
imp added a commit: rG770e04e65fbb: awk: revert upstream's attempt to disallow hex strings.Mon, Apr 15, 11:06 PM

Revision Contents
Changeset List

PathSize
contrib/
one-true-awk/
9 lines

Diff 92257

View Options

contrib/one-true-awk/lib.c

Loading...