Page MenuHomeFreeBSD
Differential D3088

Update to p4 2015.1/1126382
ClosedPublic
Actions

Authored by gordon on Jul 15 2015, 4:59 AM.
Tags
None
Referenced Files
F100681581: D3088.diff
Fri, Oct 18, 7:45 AM
Unknown Object (File)
Sat, Oct 5, 6:41 PM
Unknown Object (File)
Thu, Oct 3, 1:30 AM
Unknown Object (File)
Wed, Oct 2, 9:27 PM
Unknown Object (File)
Sun, Sep 22, 1:10 PM
Unknown Object (File)
Thu, Sep 19, 2:22 PM
Unknown Object (File)
Sep 8 2024, 3:12 AM
Unknown Object (File)
Aug 29 2024, 3:43 PM
View All Files
Subscribers
None

Details

Reviewers
erwin
mat

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

gordon updated this revision to Diff 6950.Jul 15 2015, 4:59 AM
gordon retitled this revision from to Update to p4 2015.1/1126382.
gordon updated this object.
gordon edited the test plan for this revision. (Show Details)
gordon added reviewers: mat, erwin.
gordon updated this revision to Diff 6951.Jul 15 2015, 5:04 AM

Accidentally forgot to update my local svn before generating the diff.

mat added inline comments.Jul 15 2015, 3:03 PM
devel/p4/Makefile
20–22

As they seem to be the same for every port, I wonder if those three lines should not go in the Makefile.inc. with a ?= in case one needs to override them.

gordon updated this revision to Diff 6990.Jul 16 2015, 3:59 AM

Incorporate feedback to move common lines into the Makefile.inc

gordon marked an inline comment as done.Jul 16 2015, 4:04 AM
mat accepted this revision.Jul 16 2015, 6:50 AM
mat edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2015, 6:50 AM
gordon closed this revision.Jul 18 2015, 11:49 PM

Committed as 392478.

Revision Contents
Changeset List

Diff 6951

View Options

devel/p4/Makefile

Loading...
View Options

devel/p4/distinfo.freebsd100x86

Loading...
View Options

devel/p4/distinfo.freebsd100x86_64

Loading...
View Options

devel/p4/distinfo.freebsd70x86

Loading...
View Options

devel/p4/distinfo.freebsd70x86_64

Loading...