Page MenuHomeFreeBSD

devel/py-qt5-positioning: New port - Provide PyQt5 QtPositioning module
ClosedPublic

Authored by rhurlin on Jun 20 2021, 1:25 PM.
Tags
None
Referenced Files
F102705404: D30829.diff
Sat, Nov 16, 3:04 AM
Unknown Object (File)
Sun, Nov 10, 7:55 AM
Unknown Object (File)
Sat, Nov 9, 11:51 PM
Unknown Object (File)
Sat, Nov 9, 9:36 PM
Unknown Object (File)
Wed, Nov 6, 6:07 PM
Unknown Object (File)
Tue, Oct 29, 3:32 PM
Unknown Object (File)
Sat, Oct 26, 10:16 AM
Unknown Object (File)
Sat, Oct 26, 10:15 AM
Subscribers

Details

Summary

This PyQt5 module is needed for a next release of graphics/QGIS.

This is my first attempt at making additions to the ports framework.
I hope to have understood enough the concept for the interaction of
Qt5 components and their Python bindings ;)

As maintainer of graphics/qgis I noticed during testing that QGIS
master can't be built since a few days. The reason seems to be
that QGIS recently introduced the use of the PyQt5 module
'positioning' [1]. However, this module is currently not included
in FreeBSD, even though it is in principle already included in the
underlying sources of Qt5-core and PyQt5.

[1] https://github.com/qgis/QGIS/commit/ff3be3df4068e9720da7f45f24145bff33b6cd99

Although parts of the positioning code are already used by
devel/py-qt5-location, I decided to include the overall
functionality as a new port and thus be independent of the
location module.

However, I can't judge if this way is the most clever one and I
would be happy to provide the missing module in another way.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Add missing entry in devel/Makefile.

Mk/Uses/pyqt.mk
91

Oh, it looks like py-qt5-location was missing to.

Mk/Uses/qt.mk
139 ↗(On Diff #91144)

In (C++) Qt5, there is no qt5-positioning module, QtPositioning headers and libs are in the devel/qt5-location ports.

This file is for (c++) qt modules. In (C++) Qt5,

BTW, location is missing here (and after).

devel/py-qt5-positioning/Makefile
15

s/positioning/location

devel/py-qt5/Makefile
15–16

BTW, LOCATION is missing.

Added some additions and changes for 'location', suggested by lbartoletti.

Mk/Uses/pyqt.mk
91

I added _USE_PYQT_LOCATION=location here.

Mk/Uses/qt.mk
139 ↗(On Diff #91144)

Ah, yes. I removed positioning here in _USE_QT5_ONLY.

devel/py-qt5-positioning/Makefile
15

Oops, positioning in positioning? Of course, this should be location.

devel/py-qt5/Makefile
15–16

And again, LOCATION added ;)

This revision was not accepted when it landed; it landed in state Needs Review.Jun 22 2021, 3:25 PM
This revision was automatically updated to reflect the committed changes.