Page MenuHomeFreeBSD

Remove extra kern_kldload from VBoxNetFlt-freebsd.c
ClosedPublic

Authored by madpilot on Jun 11 2021, 1:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 18, 8:23 AM
Unknown Object (File)
Jan 10 2024, 11:02 AM
Unknown Object (File)
Jan 9 2024, 12:51 PM
Unknown Object (File)
Dec 29 2023, 2:50 PM
Unknown Object (File)
Dec 23 2023, 9:07 PM
Unknown Object (File)
Dec 20 2023, 4:06 AM
Unknown Object (File)
Dec 14 2023, 11:11 PM
Unknown Object (File)
Dec 4 2023, 2:02 AM
Subscribers

Details

Summary

As reported in bug 256505 since base commit e266a0f7f001 performing kern_kldload while loading a kernel module is not allowed.

The VBoxNetFlt module does this to load ng_ether. Historically ng_ether was missing MODULE_VERSION information and could not be properly depended upon.

This has been fixed in base r238844 more than ten years ago though, so we can unconditionally use a proper MODULE_DEPEND.

Test Plan

Compiles fine in poudriere with all supported releases, and works as expected on head.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Forgot to mention, I renamed the patch file to the new naming convention.

madpilot edited the summary of this revision. (Show Details)
madpilot edited the summary of this revision. (Show Details)
madpilot edited the test plan for this revision. (Show Details)

I also plan to merge this to quarterly once committed, I'm waiting for some feedback on the bug report to make sure it works fine.

This revision is now accepted and ready to land.Jun 14 2021, 6:54 PM