ngatm: Handle errors from uni_msg_extend()
ClosedPublic
Actions

Authored by markj on Jun 2 2021, 1:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 14, 2:31 PM

	Unknown Object (File)
	Tue, Oct 14, 2:31 PM

	Unknown Object (File)
	Tue, Oct 14, 2:31 PM

	Unknown Object (File)
	Tue, Oct 14, 12:49 AM

	Unknown Object (File)
	Sat, Sep 27, 1:54 AM

	Unknown Object (File)
	Sep 16 2025, 10:56 AM

	Unknown Object (File)
	Sep 11 2025, 5:40 AM

	Unknown Object (File)
	Sep 6 2025, 12:57 AM

View All Files

Subscribers

imp

Details

Reviewers

harti

Commits

rGe755e2776ddf: ngatm: Handle errors from uni_msg_extend()

Summary

uni_msg_extend() may fail due to a memory allocation failure. In this
case, though, the message is freed, so callers shouldn't touch it.

PR: 255861
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jun 2 2021, 1:55 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 2 2021, 1:55 PM

markj requested review of this revision.Jun 2 2021, 1:55 PM

Harbormaster completed remote builds in B39662: Diff 90320.Jun 2 2021, 1:55 PM

This looks good to me. Good catch.

harti

This revision was not accepted when it landed; it landed in state Needs Review.Jun 6 2021, 8:47 PM

Closed by commit rGe755e2776ddf: ngatm: Handle errors from uni_msg_extend() (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGe755e2776ddf: ngatm: Handle errors from uni_msg_extend().

Revision Contents
Changeset List

Path

Size

sys/

contrib/

ngatm/

netnatm/

msg/

uni_ie.c

6 lines

Diff 90498

View Options

sys/contrib/ngatm/netnatm/msg/uni_ie.c

ngatm: Handle errors from uni_msg_extend()ClosedPublicActions