Fix recursive variable substitution in jail.conf
ClosedPublic
Actions

Authored by hrs on Jul 7 2015, 6:46 PM.

Tags

None

Referenced Files

	F131731257: D3018.id6759.diff
	Fri, Oct 10, 5:31 PM

	Unknown Object (File)
	Sun, Oct 5, 5:49 AM

	Unknown Object (File)
	Tue, Sep 16, 7:08 PM

	Unknown Object (File)
	Sep 6 2025, 2:34 AM

	Unknown Object (File)
	Aug 16 2025, 3:50 PM

	Unknown Object (File)
	Aug 5 2025, 10:29 AM

	Unknown Object (File)
	Aug 4 2025, 4:37 PM

	Unknown Object (File)
	Aug 4 2025, 3:06 AM

View All Files

Subscribers

imp

Details

Reviewers

jamie

Commits

rS285261: Fix offset calculation in variable substitution

Summary

As reported in PR 189139, variable substitution is broken when
A="A_${B}_C_${D}", B="BBBBB", D="DDDD_${E}_FFFFF", and E="EEEEE" are
defined.

This patch fixes the offset length calculation.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hrs updated this revision to Diff 6759.Jul 7 2015, 6:46 PM

hrs retitled this revision from to Fix recursive variable substitution in jail.conf.

hrs updated this object.

hrs edited the test plan for this revision. (Show Details)

hrs added a reviewer: jamie.

Herald added a subscriber: imp. · View Herald TranscriptJul 7 2015, 6:46 PM

Looks good to me :-)

Closed by commit rS285261: Fix offset calculation in variable substitution (authored by hrs). · Explain WhyJul 8 2015, 12:51 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

jail/

config.c

16 lines

Diff 6765

View Options

head/usr.sbin/jail/config.c

Fix recursive variable substitution in jail.confClosedPublicActions