Page MenuHomeFreeBSD

x11/sterm: only use general nonconflicting patches
ClosedPublic

Authored by kfv_kfv.io on Apr 25 2021, 9:06 PM.

Details

Reviewers
pkubaj
Summary

The user could only pick one of the three provided patches at present, where only one of them is what a desktop user usually needs. The solarized option is totally based on taste, and the open_copied_url is small enough to add manually. So I thought, it is better to have multiple options than to be obliged to pick only one, and on the other hand, the Xresources patch could be more useful for a desktop user.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 38856
Build 35745: arc lint + arc unit

Event Timeline

I would also like to add that the possibility to choose multiple options, as long as the corresponding patches don't conflict, would be so handy as the user can easily pick their options at once. If not, the process will be a little bit monotonous to clone, manually apply patches, merge, and so on. But we definitely cannot integrate all available patches within our ports since some may conflict, and then the user is forced to pick one as before, or they will get an error. That's why I recommend providing something like xresources patch that would be more useful for the daily use of a desktop user and would be tougher to add it manually.

This revision is now accepted and ready to land.May 5 2021, 10:32 PM