Page MenuHomeFreeBSD

devel/py-phabricator: Support token-based authentication
ClosedPublic

Authored by koobs on Jul 3 2015, 2:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 6, 2:53 AM
Unknown Object (File)
Jan 20 2025, 4:46 AM
Unknown Object (File)
Jan 20 2025, 2:04 AM
Unknown Object (File)
Jan 20 2025, 12:53 AM
Unknown Object (File)
Jan 19 2025, 10:29 PM
Unknown Object (File)
Jan 18 2025, 9:07 PM
Unknown Object (File)
Jan 18 2025, 10:30 AM
Unknown Object (File)
Dec 14 2024, 4:59 PM
Subscribers
None

Details

Summary

Proposed commit log:

devel/py-phabricator: Support token-based authentication

Backport upstream pull request #23 [1] that adds support for new style
token-based authentication. This PR fixes issue #22 [2]. Additionally
modify the patch to add the token argument to the and of the argument
list as per upstream pull request comment.

This change fixes errors associated with not being able to find 'user'
or 'cert' configuration keys (in ~/.arcrc) keys when using token based
authentication.

This was reproducible with deskutils/py-bugwarrior

- Sort Makefile
- Sort USE_PYTHON values
- Canonicalize regression-test invocation

[1] https://github.com/disqus/python-phabricator/pull/23
[2] https://github.com/disqus/python-phabricator/issues/22
Test Plan
  • portlint: looks fine.
  • testport: OK
  • unittest: Ran 5 tests in 0.102s - OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

koobs retitled this revision from to devel/py-phabricator: Support token-based authentication.
koobs updated this object.
koobs edited the test plan for this revision. (Show Details)
koobs added a reviewer: sbz.
sbz edited edge metadata.

LGTM. I approve your change. I was waiting a new release but it's not release yet.. Thanks!

This revision is now accepted and ready to land.Jul 14 2015, 9:06 PM

FYI

% make -C /usr/ports/devel/py-phabricator/ -VPYSETUP -VPYDISTUTILS_SETUP
setup.py
-c  "import sys; import setuptools;  __file__='setup.py'; sys.argv[0]='setup.py';  exec(compile(open(__file__, 'rb').read().replace(b'\\r\\n', b'\\n'), __file__, 'exec'))"

I really prefer the former PYSETUP.

In D2983#60932, @sbz wrote:

FYI

% make -C /usr/ports/devel/py-phabricator/ -VPYSETUP -VPYDISTUTILS_SETUP
setup.py
-c  "import sys; import setuptools;  __file__='setup.py'; sys.argv[0]='setup.py';  exec(compile(open(__file__, 'rb').read().replace(b'\\r\\n', b'\\n'), __file__, 'exec'))"

I really prefer the former PYSETUP.

I preferred it in the past too, but unfortunately it breaks test invocation for modules/packages that *dont* use setuptools (pure distutils) as it doesn't support a 'test' command by default. Wrapping the setup.py call with import setuptools (like pip does) automatically gives us access to tests_require and test_suite

This revision was automatically updated to reflect the committed changes.