Page MenuHomeFreeBSD

readelf: return error in case of invalid file
ClosedPublic

Authored by emaste on Mar 22 2021, 1:59 PM.
Tags
None
Referenced Files
F132228912: D29377.diff
Wed, Oct 15, 12:14 AM
F132151834: D29377.id.diff
Tue, Oct 14, 5:52 AM
F132151833: D29377.id86825.diff
Tue, Oct 14, 5:52 AM
F132151829: D29377.id86144.diff
Tue, Oct 14, 5:52 AM
Unknown Object (File)
Tue, Oct 14, 3:16 AM
Unknown Object (File)
Mon, Oct 13, 4:22 PM
Unknown Object (File)
Sun, Oct 12, 7:24 PM
Unknown Object (File)
Sat, Oct 4, 6:00 AM
Subscribers
None

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.

Seems ok. Some types of errors are ignored, in particular invalid files in an archive. I tried creating one and both our readelf -c and GNU readelf -c log a warning but exit with status 0. I suspect this change is sufficient to catch the most common cases.

This revision is now accepted and ready to land.Mar 22 2021, 2:33 PM
This revision was automatically updated to reflect the committed changes.