readelf: return error in case of invalid file
ClosedPublic
Actions

Authored by emaste on Mar 22 2021, 1:59 PM.

Tags

None

Referenced Files

	F132228912: D29377.diff
	Wed, Oct 15, 12:14 AM

	F132151834: D29377.id.diff
	Tue, Oct 14, 5:52 AM

	F132151833: D29377.id86825.diff
	Tue, Oct 14, 5:52 AM

	F132151829: D29377.id86144.diff
	Tue, Oct 14, 5:52 AM

	Unknown Object (File)
	Tue, Oct 14, 3:16 AM

	Unknown Object (File)
	Mon, Oct 13, 4:22 PM

	Unknown Object (File)
	Sun, Oct 12, 7:24 PM

	Unknown Object (File)
	Sat, Oct 4, 6:00 AM

View All 88 Files

Subscribers

None

Details

Reviewers

jkoshy_users.sourceforge.net
markj

Commits

rGf4c3c0189f7d: readelf: return error in case of invalid file
rG14b0c8e7687e: readelf: return error in case of invalid file
rGea444392bb5b: readelf: return error in case of invalid file

Summary

PR: 252727

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Mar 22 2021, 1:59 PM

emaste created this revision.

Seems ok. Some types of errors are ignored, in particular invalid files in an archive. I tried creating one and both our readelf -c and GNU readelf -c log a warning but exit with status 0. I suspect this change is sufficient to catch the most common cases.

This revision is now accepted and ready to land.Mar 22 2021, 2:33 PM

jkoshy_users.sourceforge.net accepted this revision.Mar 22 2021, 7:40 PM

Closed by commit rGea444392bb5b: readelf: return error in case of invalid file (authored by emaste). · Explain WhyApr 5 2021, 1:11 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGea444392bb5b: readelf: return error in case of invalid file.

emaste added a commit: rG14b0c8e7687e: readelf: return error in case of invalid file.Apr 13 2021, 6:47 PM

emaste added a commit: rGf4c3c0189f7d: readelf: return error in case of invalid file.Apr 23 2021, 3:39 PM