g_mirror: Pre-allocate timeout event structure
ClosedPublic
Actions

Authored by markj on Mar 11 2021, 5:55 PM.

Details

Reviewers

chs
imp

Commits

rG39a1b7bd9327: gmirror: Pre-allocate the timeout event structure
rG2f1cfb7f63ca: gmirror: Pre-allocate the timeout event structure

Summary

We can't do malloc(M_WAITOK) allocations in a callout.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj created this revision.Mar 11 2021, 5:55 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 11 2021, 5:55 PM

markj requested review of this revision.Mar 11 2021, 5:55 PM

Harbormaster completed remote builds in B37776: Diff 85585.Mar 11 2021, 5:55 PM

imp added reviewers: chs, imp.Mar 11 2021, 6:04 PM

Assert that the softc lock is held.

Harbormaster completed remote builds in B37778: Diff 85589.Mar 11 2021, 6:06 PM

I think this is good. I added Chuck to the list because I recall him mentioning that he was looking at something similar...

This revision is now accepted and ready to land.Mar 11 2021, 6:11 PM

Closed by commit rG2f1cfb7f63ca: gmirror: Pre-allocate the timeout event structure (authored by markj). · Explain WhyMar 11 2021, 8:46 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG2f1cfb7f63ca: gmirror: Pre-allocate the timeout event structure.

markj added a commit: rG39a1b7bd9327: gmirror: Pre-allocate the timeout event structure.Mar 18 2021, 1:25 AM

Revision Contents
Changeset List

Path

Size

sys/

geom/

mirror/

g_mirror.h

1 line

g_mirror.c

43 lines

Diff 85599

View Options

sys/geom/mirror/g_mirror.h