Page MenuHomeFreeBSD
Differential D28990

sbin/ifconfig: Use a global handle for libifconfig
ClosedPublic
Actions

Authored by freqlabs on Feb 28 2021, 8:56 PM.

Details

Reviewers
kp
Commits
rG3b71af08bb84: sbin/ifconfig: Use a global libifconfig handle
rG8b22242550c9: sbin/ifconfig: Use a global libifconfig handle
Summary

This should eventually replace the socket passed to the various handlers. In the meantime, making it global avoids repeatedly opening and closing handles.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

freqlabs requested review of this revision.Feb 28 2021, 8:56 PM
freqlabs created this revision.
kp accepted this revision.Mar 1 2021, 7:24 AM
kp added inline comments.
sbin/ifconfig/ifconfig.c
433

It doesn't make any functional difference, but we should probably do ifconfig_close(lifh); at the end of main().

This revision is now accepted and ready to land.Mar 1 2021, 7:24 AM
Closed by commit rG8b22242550c9: sbin/ifconfig: Use a global libifconfig handle (authored by freqlabs). · Explain WhyMar 3 2021, 2:17 AM
This revision was automatically updated to reflect the committed changes.
freqlabs added a commit: rG8b22242550c9: sbin/ifconfig: Use a global libifconfig handle.
freqlabs added a commit: rG3b71af08bb84: sbin/ifconfig: Use a global libifconfig handle.Mar 17 2021, 10:26 PM

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
9 lines
9 lines
6 lines
5 lines
9 lines
9 lines
9 lines
14 lines

Diff 85029

View Options

sbin/ifconfig/carp.c

Loading...
View Options

sbin/ifconfig/ifbridge.c

Loading...
View Options

sbin/ifconfig/ifclone.c

Loading...
View Options

sbin/ifconfig/ifconfig.h

Loading...
View Options

sbin/ifconfig/ifconfig.c

Loading...
View Options

sbin/ifconfig/ifgroup.c

Loading...
View Options

sbin/ifconfig/iflagg.c

Loading...
View Options

sbin/ifconfig/sfp.c

Loading...