Page MenuHomeFreeBSD

Rework ports dependency
ClosedPublic

Authored by bapt on Jun 24 2015, 6:13 AM.
Tags
None
Referenced Files
F103877005: D2897.diff
Sat, Nov 30, 3:02 PM
Unknown Object (File)
Fri, Nov 29, 10:03 PM
Unknown Object (File)
Fri, Nov 29, 1:55 PM
Unknown Object (File)
Sun, Nov 24, 11:57 AM
Unknown Object (File)
Sun, Nov 24, 3:58 AM
Unknown Object (File)
Sun, Nov 24, 2:05 AM
Unknown Object (File)
Sat, Nov 23, 11:03 PM
Unknown Object (File)
Fri, Nov 22, 3:11 AM
Subscribers

Details

Summary

Externalize dependency checking

That allows more fine grain dependency checking:

  • ensure the syntax is ok
  • test after the dependency has been installed that it actually really fullfill the pattern searched
  • unify lib-depends with other dependencies
  • allow to extend easily in the futur

While here remove _DEPENDS_ALWAYS which was already half broken

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt retitled this revision from to Rework ports dependency.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: portmgr.
bapt set the repository for this revision to rP FreeBSD ports repository.
antoine added inline comments.
Mk/Scripts/do-depends.sh
147 ↗(On Diff #6420)

Currently, find-libs doesn't handle full path

Also, libfoo.so.number needs to be handled

bapt edited edge metadata.

Allow origin to be relative
Fix lib*.so*

bapt marked an inline comment as done.Jun 24 2015, 8:50 AM

Last minute changes are bad

bapt removed rP FreeBSD ports repository as the repository for this revision.
Mk/Scripts/do-depends.sh
38 ↗(On Diff #6425)

pkgbase is empty here

46 ↗(On Diff #6425)

I think you should put back the rm -f ${WRKDIR}/pkg-static for the NO_WRKSUBDIR + do things with * ports

bapt set the repository for this revision to rP FreeBSD ports repository.
bapt marked 2 inline comments as done.

With this version, there are 3 new failures:

+ {"origin"=>"deskutils/pinot", "pkgname"=>"pinot-1.06_10", "phase"=>"lib-depends", "errortype"=>"???"}
+ {"origin"=>"devel/armv6-freebsd10.0-xdev", "pkgname"=>"armv6-freebsd10.0-xdev-10.0", "phase"=>"pkg-depends", "errortype"=>"???"}
+ {"origin"=>"java/icedtea-web", "pkgname"=>"icedtea-web-1.5.2", "phase"=>"pkg-depends", "errortype"=>"???"}

http://package23.nyi.freebsd.org/data/101amd64-default-D2897/2015-06-25_19h45m00s/logs/errors/pinot-1.06_10.log
-> has \+ in LIB_DEPENDS

http://package23.nyi.freebsd.org/data/101amd64-default-D2897/2015-06-25_19h45m00s/logs/errors/armv6-freebsd10.0-xdev-10.0.log
-> has SETENV= env -i

http://package23.nyi.freebsd.org/data/101amd64-default-D2897/2015-06-25_19h45m00s/logs/errors/icedtea-web-1.5.2.log
-> has SH= ${bash_CMD}

  • Externalize dependency checking
  • return if everything went fine when building packages
  • Fix lib support to accept lib*.so*
  • last minute changes are bad!
  • grmbl
  • Fix pkgbase being empty
  • Catch nonexistent before any other files
  • /nonexistent should be rechecked
  • Do not pollute build with WRKDIR
  • Prefix all variable by dp_ to avoid collision when the scripts will run make
antoine added a reviewer: antoine.

Exp-runs look good

There is 1 new failure, but it's broken in QAT mode too:
http://package18.nyi.freebsd.org/data/93amd64-default-D2897/2015-06-28_10h25m01s/logs/errors/elasticsearch-river-rabbitmq-2.6.0.log
(the port wants elasticsearch >= 1.6 but 1.5 is in the tree)

This revision is now accepted and ready to land.Jun 28 2015, 1:43 PM
This revision was automatically updated to reflect the committed changes.