cp: change flags from integers to booleans
AcceptedPublic
Actions

Authored by ehem_freebsd_m5p.com on Feb 27 2021, 1:02 AM.

Details

Reviewers

Summary

Using int for boolean values is a long tradition. Since there is now
substantial standardization for boolean types in C, use the standards
and have these booleans be bool instead.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37425
Build 34314: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Feb 27 2021, 1:02 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptFeb 27 2021, 1:02 AM

ehem_freebsd_m5p.com requested review of this revision.Feb 27 2021, 1:02 AM

Harbormaster completed remote builds in B37424: Diff 84776.Feb 27 2021, 1:02 AM

Hmm, seems arc diff doesn't quite work the way I thought it did...

cp: change flags from integers to booleans

Using int for boolean values is a long tradition. Since there is now
substantial standardization for boolean types in C, use the standards
and have these booleans be bool instead.

Harbormaster completed remote builds in B37425: Diff 84777.Feb 27 2021, 1:08 AM

ehem_freebsd_m5p.com added a reviewer: asomers.Feb 27 2021, 1:13 AM

asomers accepted this revision.Feb 27 2021, 1:20 AM

This revision is now accepted and ready to land.Feb 27 2021, 1:20 AM

ehem_freebsd_m5p.com edited the summary of this revision. (Show Details)Feb 27 2021, 1:54 AM

Little bit of funkiness in the original differential due to learning about how Phabricator handles things. Update was simply chopping the squashed message back to what it should have been.