Page MenuHomeFreeBSD

filemon should hold proctree_lock at least during pid check
Needs ReviewPublic

Authored by sjg on Jun 19 2015, 6:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 4, 1:06 AM
Unknown Object (File)
Dec 9 2024, 4:17 AM
Unknown Object (File)
Nov 14 2024, 3:35 PM
Unknown Object (File)
Nov 1 2024, 9:16 PM
Unknown Object (File)
Nov 1 2024, 9:16 PM
Unknown Object (File)
Nov 1 2024, 9:16 PM
Unknown Object (File)
Nov 1 2024, 9:16 PM
Unknown Object (File)
Nov 1 2024, 9:04 PM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

filemon's pid check needs to guard against changes to proc tree while it is walking up the list.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sjg retitled this revision from to filemon should hold proctree_lock at least during pid check.
sjg updated this object.
sjg edited the test plan for this revision. (Show Details)
kib added inline comments.
sys/dev/filemon/filemon_wrapper.c
89

sx_slock should be enough there

89–90

This is wrong condition. You should use something like while (p != initproc).

97

This should be spelled p = proc_realparent(p);

implement suggested changes