Page MenuHomeFreeBSD

epoll: Store epoll_event udata member in ext member of kevent.
ClosedPublic

Authored by wulf on Jan 14 2021, 8:51 PM.
Tags
None
Referenced Files
F122489153: D28169.id83515.diff
Sat, Jul 5, 5:46 PM
Unknown Object (File)
Wed, Jul 2, 3:27 AM
Unknown Object (File)
Mon, Jun 30, 8:30 AM
Unknown Object (File)
Fri, Jun 27, 4:20 AM
Unknown Object (File)
Wed, Jun 25, 5:27 AM
Unknown Object (File)
Fri, Jun 13, 5:41 PM
Unknown Object (File)
May 17 2025, 11:29 PM
Unknown Object (File)
Apr 28 2025, 1:31 PM

Details

Summary

Current epoll implementation stores udata fields of epoll_event
structure in special dynamically-sized table rather than in udata field
of backing kevent structure because of 2 reasons:

  1. Kevent's udata size is smaller than epoll's on 32-bit archs.
  2. Kevent's udata can be clobbered on execution EPOLL_CTL_ADD as kqueue modifies existing event while epoll returns error in this case.

After r320043 has introduced 4 new 64bit user data members (ext[]),
we can store epoll udata in one of them and drop aforementioned table.
According to kqueue_register() source code ext members are not updated
when existing kevent is modified that fixes p.2.

As a side effect the patch fixes PR/252582.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable