Page MenuHomeFreeBSD

New port: mail/pysasl: Pure Python SASL client and server library
ClosedPublic

Authored by nc on Jan 7 2021, 4:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 7:07 PM
Unknown Object (File)
Wed, Apr 24, 7:07 PM
Unknown Object (File)
Wed, Apr 24, 7:04 PM
Unknown Object (File)
Wed, Apr 24, 7:04 PM
Unknown Object (File)
Wed, Apr 24, 6:50 PM
Unknown Object (File)
Sun, Apr 21, 7:41 PM
Unknown Object (File)
Tue, Apr 16, 4:49 AM
Unknown Object (File)
Feb 15 2024, 9:49 PM
Subscribers

Details

Summary

New port: mail/pysasl: Pure Python SASL client and server library

Test Plan

Passes poudriere.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nc requested review of this revision.Jan 7 2021, 4:55 PM
0mp requested changes to this revision.Jan 7 2021, 8:09 PM
0mp added inline comments.
mail/py-pysasl/Makefile
5 ↗(On Diff #81817)

Just an idea: should we add security category as well?

15 ↗(On Diff #81817)

Please make sure that the version of the port dependency matches the actual requirements defined in requirement.txt, setup.py or equivalent.

This document might give you an idea of what's good to check for Python ports: https://wiki.freebsd.org/Python/PortsPolicy

18 ↗(On Diff #81817)

If this port installs a CLI, it's a good idea to define concurrent here. See https://wiki.freebsd.org/Python/PortsPolicy#concurrent.

20 ↗(On Diff #81817)

Personally, I use portfmt to format makefiles. It is not mentioned by our handbook, but it's nevertheless the best tool available for formatting port makefiles we have. I encourage you to give it a try :)

27 ↗(On Diff #81817)

Incorrect order of make variables. Please consult https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-order. There are a couple of helper programs which can point out ordering problems: portlint and portclippy.

This revision now requires changes to proceed.Jan 7 2021, 8:09 PM
nc marked 5 inline comments as done.

Add 0mp@'s suggestions to this port.

Seems fine.

Approved!

This revision is now accepted and ready to land.Jan 7 2021, 9:33 PM