Page MenuHomeFreeBSD

Add me (nc@) as a Ports committer
ClosedPublic

Authored by nc on Jan 4 2021, 8:18 PM.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nc requested review of this revision.Jan 4 2021, 8:18 PM
nc created this revision.

Probably from a Phabricator bug, but I could only see the first commit in my previous patch.

0mp requested changes to this revision.Jan 4 2021, 9:13 PM

BTW, could you try to submit future patches with context? The easiest way is to configure arcanist (https://www.freshports.org/devel/arcanist/). It makes reviewing a bit easier. Thank you :)

en_US.ISO8859-1/articles/contributors/contrib.committers.xml
988

Hmmm, I think that this file should be sorted by surname.

share/xml/news.xml
37

Technically, portmgr sent the email on Jan, 2. ;)

39

Unnecessary space after <p>?

This revision now requires changes to proceed.Jan 4 2021, 9:13 PM

Make some formatting corrections.

Seems fine. Please, before you commit,

  1. check your XML changes with igor (see https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/book.html for more info).
  2. make sure that your git setup follows the recommendations from this repo: https://github.com/bsdimp/freebsd-git-docs
  3. before you push, take a look at git log if everything is fine (not only the patch itself but also the metadata like author name and email)

BTW, I'd like to ask you to add the commit message you are going to submit in the description of the patch here on Phabricator. This way I'll be able to review the contents of the commit message and introduce you to some conventions if necessary.

Almost there... :D

The commit message I want to use is:

doc: Add committer entries for Neel Chauhan <nc>

Steps 1-4 from the Committer's guide:
  - Add entries for Neel Chauhan <nc>
  - Add GPG key

Reviewed by:            0mp (mentor)
Approved by:            0mp (mentor)
Differential Revision:  https://reviews.freebsd.org/D27957

Is this okay?

I think that the doc: could be dropped. Also, (mentor) can be removed from the Reviewed by entry in my opinion. Otherwise, seems pretty nice!

This revision is now accepted and ready to land.Jan 4 2021, 9:47 PM

I;ll use this:

Add committer entries for Neel Chauhan <nc>

Steps 1-4 from the Committer's guide:
  - Add entries for Neel Chauhan <nc>
  - Add GPG key

Reviewed by:            0mp
Approved by:            0mp
Differential Revision:  https://reviews.freebsd.org/D27957
In D27957#624548, @neel_neelc.org wrote:

I;ll use this:

Add committer entries for Neel Chauhan <nc>

Steps 1-4 from the Committer's guide:
  - Add entries for Neel Chauhan <nc>
  - Add GPG key

Reviewed by:            0mp
Approved by:            0mp
Differential Revision:  https://reviews.freebsd.org/D27957

I'd leave (mentor) in Approved by because the role is imporant there. I'd just drop it from the Reviewed by part.

Otherwise, feel free to commit! :)

This revision was automatically updated to reflect the committed changes.