Page MenuHomeFreeBSD

svn hook for the empty files detection
ClosedPublic

Authored by ak on Jun 24 2014, 12:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 9 2024, 2:02 AM
Unknown Object (File)
Jan 3 2024, 2:27 PM
Unknown Object (File)
Nov 20 2023, 7:25 AM
Unknown Object (File)
Nov 18 2023, 10:16 AM
Unknown Object (File)
Nov 18 2023, 9:27 AM
Unknown Object (File)
Nov 18 2023, 7:02 AM
Unknown Object (File)
Nov 18 2023, 6:34 AM
Unknown Object (File)
Apr 26 2023, 4:03 AM
Subscribers

Details

Reviewers
mat
Group Reviewers
portmgr
Summary

The svn hook for the empty files detection. Implementation is shamelessly stolen from antoine's svnadmin/hooks/scripts/stage-only.sh

Test Plan

Add the hook, make a few commits.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ak retitled this revision from to svn hook for the empty files detection.
ak updated this object.
ak edited the test plan for this revision. (Show Details)
ak added a reviewer: portmgr.
ak set the repository for this revision to rP FreeBSD ports repository.

Mmmm, do we have an empty file problem ?

Several appear every month. I can continue to remove them, but IMO svn hook will be a better solution.

mat added a reviewer: mat.

If you've tested it and it works, go with it. Don't forget to hook it up in hooks/pre-commit

This revision is now accepted and ready to land.Jun 24 2014, 12:37 PM

Also, don't forget to add all the relevant props, especially the executable one :-)

Should we not also check for empty directories ?

Should we not also check for empty directories

The hook does that. I've uploaded the correct patch.
Sorry about that.

ak edited edge metadata.

Updated patch, now with check for empty directories.

In D279#16, @ak wrote:

Updated patch, now with check for empty directories.

Looks good to me.

Commited, thanks for review.