Page MenuHomeFreeBSD

efibootmgr: fix an incorrect error handling check
ClosedPublic

Authored by mhorne on Nov 30 2020, 7:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 4, 8:04 AM
Unknown Object (File)
Sat, Sep 27, 11:49 PM
Unknown Object (File)
Mon, Sep 22, 2:25 AM
Unknown Object (File)
Sun, Sep 21, 1:06 PM
Unknown Object (File)
Sun, Sep 21, 3:25 AM
Unknown Object (File)
Thu, Sep 18, 9:24 PM
Unknown Object (File)
Thu, Sep 18, 5:14 AM
Unknown Object (File)
Aug 2 2025, 6:57 AM
Subscribers
None

Details

Summary

efivar_device_path_to_unix_path() returns standard error codes on
failure and zero on success. Checking for a return value less than zero
means that the actual failure cases won't be handled. This could
manifest as a segfault during the subsequent call to printf().

Test Plan

With this patch applied, efibootmgr -E doesn't segfault on my system, and
instead gives:
efibootmgr: Can't convert to unix path

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.
mhorne retitled this revision from efibootmgr: fix an error return check to efibootmgr: fix an incorrect error handling check.Nov 30 2020, 7:46 PM
This revision is now accepted and ready to land.Nov 30 2020, 8:41 PM
This revision was automatically updated to reflect the committed changes.