Page MenuHomeFreeBSD
Differential D26823

devmatch(8): Respect mask field when matching strings.
ClosedPublic
Actions

Authored by wulf on Oct 17 2020, 12:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 6, 11:02 PM
Unknown Object (File)
Sun, Nov 2, 2:39 AM
Unknown Object (File)
Tue, Oct 21, 7:52 AM
Unknown Object (File)
Tue, Oct 21, 7:52 AM
Unknown Object (File)
Tue, Oct 21, 7:52 AM
Unknown Object (File)
Mon, Oct 20, 8:51 PM
Unknown Object (File)
Sun, Oct 12, 3:56 AM
Unknown Object (File)
Oct 7 2025, 6:45 AM
View All 88 Files
Subscribers
None

Details

Reviewers
imp
Commits
rS367676: MFC r367237:
rS367237: devmatch(8): Respect mask field when matching strings of Z type.
Summary

Currently, only integer fields of descriptor string can be masked out for matching. This patch adds support for masking of 'Z' type field.

While here, add debug output for this action.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wulf requested review of this revision.Oct 17 2020, 12:19 AM
wulf created this revision.
imp added inline comments.Oct 17 2020, 12:24 AM
sbin/devmatch/devmatch.c
352 ↗(On Diff #78338)

When would bit by < 0?

wulf added inline comments.Oct 17 2020, 12:32 AM
sbin/devmatch/devmatch.c
352 ↗(On Diff #78338)

It starts iterating from -1. May be the first field is dedicated to mask itself?

imp added inline comments.Oct 17 2020, 12:36 AM
sbin/devmatch/devmatch.c
352 ↗(On Diff #78338)

Yes.... I don't think the check is needed, but I'm not sure

wulf added inline comments.Oct 17 2020, 12:39 AM
sbin/devmatch/devmatch.c
352 ↗(On Diff #78338)

I borrowed the check from integer case to not introduce new bugs.

imp accepted this revision.Oct 17 2020, 12:53 AM
imp added inline comments.
sbin/devmatch/devmatch.c
352 ↗(On Diff #78338)

I borrowed the check from integer case to not introduce new bugs.

Fair enough. Keep it...

This revision is now accepted and ready to land.Oct 17 2020, 12:53 AM
Closed by commit rS367237: devmatch(8): Respect mask field when matching strings of Z type. (authored by wulf). · Explain WhyOct 31 2020, 10:04 PM
This revision was automatically updated to reflect the committed changes.
wulf added a commit: rS367237: devmatch(8): Respect mask field when matching strings of Z type..
wulf added a commit: rS367676: MFC r367237:.Nov 14 2020, 11:52 AM

Revision Contents
Changeset List

PathSize
head/
sbin/
devmatch/
5 lines

Diff 79020

View Options

head/sbin/devmatch/devmatch.c

Loading...