audio/pulseeffects: Update port to 4.8.5

[daniel_shafer.cc]

Summary

audio/pulseffects: Update port to 4.8.5

Changelog can be viewed here:
https://github.com/wwmm/pulseeffects/blob/master/CHANGELOG.md

Several things were restructured due to major changes in the application's file structure and naming conventions.

Test Plan

portlint: WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
0 fatal errors and 1 warning found. - gettext is required for the port to compile.
poudriere: (testport, 12Samd64, good)

[tcberner]

Moin moin

You might want to look into

The operation will free 4 MiB.
[130amd64-svn] [1/1] Deinstalling pulseeffects-4.8.2...
[130amd64-svn] [1/1] Deleting files for pulseeffects-4.8.2: .......... done
===========================================================================
=>> Checking for extra files and directories
=>> Error: Files or directories modified:
share/icons/hicolor/icon-theme.cache
build of audio/pulseeffects | pulseeffects-4.8.2 ended at Fri Oct  2 19:01:54 CEST 2020

[daniel_shafer.cc]

audio/pulseffects: Update port to 4.8.5

Changelog can be viewed here:
https://github.com/wwmm/pulseeffects/blob/master/CHANGELOG.md

4.8 is the final release for PulseAudio, other than security releases
to the 4.8 branch there will be no new features or updates.  
PulseEffects 5+ will require PipeWire and not work for PulseAudio.

I updated the port to 4.8.5.

The issue pointed out by tcberner seems to be a problem that
existed in the past with the INSTALL_ICONS option, I am not
sure how to get past it, the problem still appears to be open.

See: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246102