Passify a new clang warning
ClosedPublic
Actions

Authored by brooks on Sep 29 2020, 8:24 PM.

Tags

None

Referenced Files

	F141224076: D26593.id77648.diff
	Fri, Jan 2, 3:39 PM

	Unknown Object (File)
	Wed, Dec 31, 12:09 AM

	Unknown Object (File)
	Wed, Dec 31, 12:09 AM

	Unknown Object (File)
	Sun, Dec 14, 9:30 AM

	Unknown Object (File)
	Sun, Dec 14, 9:30 AM

	Unknown Object (File)
	Nov 27 2025, 6:43 PM

	Unknown Object (File)
	Nov 19 2025, 9:50 AM

	Unknown Object (File)
	Nov 14 2025, 1:16 PM

View All 86 Files

Subscribers

None

Details

Reviewers

Commits

rP550844: Update to version 3.1.6

Summary

Clang 12 warns about certain cases of string concatenation in array
initialization. Adding parentheses siliences this warning.

Submitted upstream as https://git.yzena.com/gavin/bc/pulls/6

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks requested review of this revision.Sep 29 2020, 8:24 PM

brooks created this revision.

Harbormaster completed remote builds in B33884: Diff 77648.Sep 29 2020, 8:24 PM

I've submitted here because upstream seems to want me to do that (and also to document the issue if someone else tries building FreeBSD with an up-to-date llvm.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2020, 3:36 PM

Closed by commit rP550844: Update to version 3.1.6 (authored by se). · Explain Why

This revision was automatically updated to reflect the committed changes.

se added a commit: rP550844: Update to version 3.1.6.

Both the port and the contrib sources in -CURRENT have been updated to version 3.1.6 to fix this issue.
No MFC to 12-STABLE is planned at this time, since the issue does only affect systems with LLVM-12 as the base compiler.