Page MenuHomeFreeBSD

Passify a new clang warning
ClosedPublic

Authored by brooks on Sep 29 2020, 8:24 PM.

Details

Summary

Clang 12 warns about certain cases of string concatenation in array
initialization. Adding parentheses siliences this warning.

Submitted upstream as https://git.yzena.com/gavin/bc/pulls/6

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

brooks created this revision.

I've submitted here because upstream seems to want me to do that (and also to document the issue if someone else tries building FreeBSD with an up-to-date llvm.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2020, 3:36 PM
Closed by commit rP550844: Update to version 3.1.6 (authored by se). · Explain Why
This revision was automatically updated to reflect the committed changes.

Both the port and the contrib sources in -CURRENT have been updated to version 3.1.6 to fix this issue.
No MFC to 12-STABLE is planned at this time, since the issue does only affect systems with LLVM-12 as the base compiler.