Page MenuHomeFreeBSD

bsd.port.mk: Handle incorrect binary aliases gracefully
ClosedPublic

Authored by 0mp on Sep 25 2020, 9:02 AM.

Details

Summary
bsd.port.mk: Handle incorrect binary aliases gracefully

Currently, if the src element of a BINARY_ALIAS pair is missing, the ports
framework would just print out the help message of install(1) and exit with a
failure. This might be hard to debug for novice ports users.

Let's introduce a check, which would allow us to print that the src component
is missing.

This situation happens more often than it seems to. For example, BINARY_ALIAS
tend to blow up when used for test dependencies, because binary aliases are
created before test dependencies are installed. This leads to a lot of
confusion for my experience.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

0mp requested review of this revision.Sep 25 2020, 9:02 AM

Assuming this was tested on all our supported releases.

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Sep 28, 1:47 PM
This revision was automatically updated to reflect the committed changes.