new port: security/rubygem-attr_required
ClosedPublic
Actions

Authored by mmoll on May 16 2015, 1:11 AM.

Details

Reviewers

swills
mat

Summary

Taken from PR 199921 with minor modifications.
Proposed commit message:

new port: security/rubygem-attr_required

This gem provides implementations of attr_required and attr_optional
(like attr_accessor) for Ruby.

WWW: https://github.com/nov/attr_required

PR:		199921
Submitted by:	Torsten Zuehlsdorff <ports@toco-domains.de>
Approved by:	swills (mentor), mat (mentor)

Test Plan

poudriere: http://space.kvedulv.de/FreeBSD/rubygem-attr_required-1.0.0.log
portlint:

mmoll@marduk:/svn/ports/security/rubygem-attr_required$ portlint -ACNc
WARN: Makefile: [19]: possible use of "${CHMOD}" found. Use @(owner,group,mode) syntax or @owner/@group operators in pkg-plist instead.
0 fatal errors and 1 warning found.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

mmoll updated this revision to Diff 5415.May 16 2015, 1:11 AM

mmoll retitled this revision from to new port: security/rubygem-attr_required.

mmoll updated this object.

mmoll edited the test plan for this revision. (Show Details)

mmoll added reviewers: swills, mat.

got bitten when moving dir from git to svn

*sigh*

mmoll added inline comments.May 16 2015, 1:21 AM

devel/rubygem-attr_required/Makefile

Without this I'm getting

===>   Registering installation for rubygem-attr_required-1.0.0
Installing rubygem-attr_required-1.0.0...
===> SECURITY REPORT: 
      This port has installed the following world-writable files/directories.
/usr/local/lib/ruby/gems/2.1/gems/attr_required-1.0.0/lib/attr_optional.rb
/usr/local/lib/ruby/gems/2.1/gems/attr_required-1.0.0/.gitignore
/usr/local/lib/ruby/gems/2.1/gems/attr_required-1.0.0/LICENSE
/usr/local/lib/ruby/gems/2.1/gems/attr_required-1.0.0/.travis.yml
/usr/local/lib/ruby/gems/2.1/gems/attr_required-1.0.0/Gemfile
/usr/local/lib/ruby/gems/2.1/gems/attr_required-1.0.0/Rakefile
/usr/local/lib/ruby/gems/2.1/gems/attr_required-1.0.0/VERSION
/usr/local/lib/ruby/gems/2.1/gems/attr_required-1.0.0/spec/spec_helper.rb
/usr/local/lib/ruby/gems/2.1/gems/attr_required-1.0.0/README.rdoc
/usr/local/lib/ruby/gems/2.1/gems/attr_required-1.0.0/.rspec

Unfortunately I couldn't trace the cause. The files in the original .gem seem OK.

mat added inline comments.May 16 2015, 9:04 AM

devel/rubygem-attr_required/Makefile
19	Maybe some umask problem. Was this as a user, or as root ?

mmoll added inline comments.May 16 2015, 2:25 PM

devel/rubygem-attr_required/Makefile
19	As root, it also happens in poudriere. I'm not aware of any umask related settings on my systems and that's also the only port where such unexpected things happen.

mat accepted this revision.May 16 2015, 5:22 PM

mat edited edge metadata.

mat added inline comments.

devel/rubygem-attr_required/Makefile
19	As a note, you should always build ports for testing as a normal user, not root. Adding `BUILD_AS_NON_ROOT=yes` to your `poudriere.conf` is a good thing too.

This revision is now accepted and ready to land.May 16 2015, 5:22 PM

mmoll added inline comments.May 16 2015, 7:43 PM

devel/rubygem-attr_required/Makefile
19	I see, will do. For the full record, in the non-poudriere case I did build it as user, but installed it as root and only after installing the message is shown.

committed in rP386573

mat added inline comments.May 16 2015, 9:03 PM

devel/rubygem-attr_required/Makefile
19	Note all of `make stage` can, and should, be done a user. I almost never use `make install`, the only thing it does is installing the package it built during `make stage`, so unless there is a pkg-install/deinstall script, and it has been changed, installing the package won't do anything interesting.