Page MenuHomeFreeBSD

Do not mention loading modules via loader.conf
ClosedPublic

Authored by 0mp on Mon, Jun 29, 1:41 PM.

Details

Summary
Do not mention loading modules via loader.conf

It is generally discouraged to load graphics kernel modules via loder.conf(5).
According to kevans@, loader.conf loading Nvidia modules is fragile for UEFI on FreeBSD <= 12.1.              
It might work, but those modules are large and ; the loader's staging area for 
insufficient to contain kernel, Nvidia modules, and much of anything else at the same time.


Also, while here, encourage people to use sysrc to modify the contents of
rc.conf(5).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

0mp created this revision.Mon, Jun 29, 1:41 PM
0mp requested review of this revision.Mon, Jun 29, 1:41 PM
0mp added inline comments.Mon, Jun 29, 1:42 PM
x11/nvidia-driver/Makefile
16 ↗(On Diff #73873)

Actually, I'll probably need to bump PORTREVISION for those other nvidia-driver-* ports as well.

0mp updated this revision to Diff 73874.Mon, Jun 29, 1:44 PM

Bump PORTREVISION in dependant ports as well

0mp added inline comments.Mon, Jun 29, 1:47 PM
x11/nvidia-driver/files/pkg-message.in
7 ↗(On Diff #73874)

Hmm, I've removed # here so that the comments align nicely when indenting with tabs BTW. Let me know if you like it or not :)

0mp edited the summary of this revision. (Show Details)Mon, Jun 29, 2:28 PM
0mp edited the summary of this revision. (Show Details)Mon, Jun 29, 2:43 PM
danfe accepted this revision.Tue, Jun 30, 6:47 AM

I'm accepting it proactively (even though I've suggested one what seems to me as an improvement, I'm fine if you prefer your original version and won't argue over it), thanks!

x11/nvidia-driver/files/pkg-message.in
7 ↗(On Diff #73874)

My initial reaction was "well it supposed to show that these comments require superuser privileges" but given your explanation (I'm also a big fan when things align nicely) I'm fine with dropping the root prompt. Just make sure you indent with tab(s), not spaces.

10 ↗(On Diff #73874)

Hm, perhaps replace "for example" with "either manually or", so it reads as ... variable in /etc/rc.conf, either manually or by running sysrc... What do you think?

This revision is now accepted and ready to land.Tue, Jun 30, 6:47 AM
This revision was automatically updated to reflect the committed changes.
0mp added a comment.Tue, Jun 30, 7:42 AM

Thanks! I incorporated both suggestions.