Page MenuHomeFreeBSD

databases/puppetdb: update to 2.3.4
ClosedPublic

Authored by mmoll on May 11 2015, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 1 2024, 7:41 AM
Unknown Object (File)
Sep 7 2024, 7:07 PM
Unknown Object (File)
Sep 7 2024, 11:49 AM
Unknown Object (File)
Sep 1 2024, 8:56 PM
Unknown Object (File)
Sep 1 2024, 8:55 PM
Unknown Object (File)
Sep 1 2024, 8:55 PM
Unknown Object (File)
Sep 1 2024, 8:55 PM
Unknown Object (File)
Apr 20 2024, 5:48 PM
Subscribers
None

Details

Reviewers
swills
mat
Summary

I submitted PR 199187 for 2.3.2, in the meanwhile PR 199624 for 2.3.3 got submitted. I'm submitting an update to 2.3.4 here, including portlint fixes.

Proposed commit message:

databases/puppetdb: update to 2.3.4

Also pet portlint (makepatch) and add LICENSE.

PR:		199187 [1]
PR:		199624 [2]
Submitted by:	Geoff Garside <freebsd@geoffgarside.co.uk> [2]
Approved by:	swills (mentor), mat (mentor)
Approved by:	Zach Leslie <xaque208@gmail.com> (maintainer) [1]

portlint output (warning because of "rake install"):

mmoll@marduk:/svn/ports/databases/puppetdb$ portlint -ACNc
WARN: Makefile: [0]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
0 fatal errors and 1 warning found.
Test Plan

http://space.kvedulv.de/FreeBSD/puppetdb-2.3.4.log - Also, I'm using this as my PuppetDB right now.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

mmoll retitled this revision from to databases/puppetdb: update to 2.3.4.
mmoll updated this object.
mmoll edited the test plan for this revision. (Show Details)
mmoll added reviewers: swills, mat.
mat requested changes to this revision.May 11 2015, 9:55 PM
mat edited edge metadata.

Mmmm, reading what portlint says is good, applying it blindly is not.

In this instance, don't regenerate the patches for the sake of regenerating the patches, if a patch needs to be updated, sure, go ahead and regenerate it with make makepatch, but don't regenerate them all only to shut portlint up. Please, svn revert -R files and resubmit.

This revision now requires changes to proceed.May 11 2015, 9:55 PM
mmoll edited edge metadata.

reverted generation of patches

mat edited edge metadata.

Once you get the ok from the maintainer, feel free to commit it ?

This revision is now accepted and ready to land.May 12 2015, 10:40 AM