Page MenuHomeFreeBSD

x11/libxfce4menu: Update fix for leaked keygrabs when layout changes
ClosedPublic

Authored by madpilot on May 25 2020, 8:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 2:57 AM
Unknown Object (File)
Mon, Oct 13, 1:21 AM
Unknown Object (File)
Sat, Oct 11, 10:56 PM
Unknown Object (File)
Tue, Sep 30, 1:11 AM
Unknown Object (File)
Thu, Sep 18, 9:05 PM
Unknown Object (File)
Aug 24 2025, 9:44 PM
Unknown Object (File)
Aug 17 2025, 6:52 PM
Unknown Object (File)
Aug 6 2025, 6:15 PM
Subscribers

Details

Summary

Update to the fix proposed by cem in [1].

This patch uses the glib GArray API to have growing list of old keycodes instead of using a fixed size array.

The patch is submitted upstream at [2].

[1] https://reviews.freebsd.org/D24338

[2] https://gitlab.xfce.org/xfce/libxfce4ui/-/merge_requests/1

Test Plan

I'm runing this on my machine without problems.

I'd like someone else to confirm it works properly.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

x11/libxfce4menu/files/patch-libxfce4kbd-private_xfce-shortcuts-grabber.c
17 ↗(On Diff #72217)

I suspect this check is not really necessary anymore, but not completely sure.

I also was not able to find documentation about the behavior of g_array_index() when one asks to access an element beyond the end of the array.

Align patch with the one sent upstream.

madpilot accepted this revision.
This revision is now accepted and ready to land.Jul 15 2020, 1:24 PM