Page MenuHomeFreeBSD

x11/libxfce4menu: Update fix for leaked keygrabs when layout changes
ClosedPublic

Authored by madpilot on May 25 2020, 8:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 26, 6:47 PM
Unknown Object (File)
Fri, Jun 26, 12:20 AM
Unknown Object (File)
Fri, Jun 19, 7:17 PM
Unknown Object (File)
Tue, Jun 16, 2:04 PM
Unknown Object (File)
Mon, Jun 15, 9:35 PM
Unknown Object (File)
Sun, Jun 14, 1:27 AM
Unknown Object (File)
May 28 2026, 12:05 PM
Unknown Object (File)
May 26 2026, 1:14 PM
Subscribers

Details

Summary

Update to the fix proposed by cem in [1].

This patch uses the glib GArray API to have growing list of old keycodes instead of using a fixed size array.

The patch is submitted upstream at [2].

[1] https://reviews.freebsd.org/D24338

[2] https://gitlab.xfce.org/xfce/libxfce4ui/-/merge_requests/1

Test Plan

I'm runing this on my machine without problems.

I'd like someone else to confirm it works properly.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

x11/libxfce4menu/files/patch-libxfce4kbd-private_xfce-shortcuts-grabber.c
17 ↗(On Diff #72217)

I suspect this check is not really necessary anymore, but not completely sure.

I also was not able to find documentation about the behavior of g_array_index() when one asks to access an element beyond the end of the array.

Align patch with the one sent upstream.

madpilot accepted this revision.
This revision is now accepted and ready to land.Jul 15 2020, 1:24 PM