Page MenuHomeFreeBSD

Update libgit2 to 0.22.x.
ClosedPublic

Authored by kwm on May 6 2015, 8:31 PM.

Details

Reviewers
swills
koobs
wg
Summary

Update libgit2 to the 0.22.x series which brings in API/ABI changes (yay fun).
Update libgit2-glib to 0.22.x series to fix the build with libgit2 0.22.x.
Update gitg to 3.16.1 to make it build agains libgit2-glib 0.22.x.
Update py-pygit2 to 0.22.0.
Update rubygem-rugged to 0.22.1b1 which is a pre-release but it builds with

libgit2 0.22.x..
Test Plan

libgit2, libgit2-glib and gitg are in the GNOME 3.16 repo, and work there.
py-pygit2 and rubygem-rugged need testing. After the rugged port is fixed

since it installs .o files...??

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

kwm updated this revision to Diff 5239.May 6 2015, 8:31 PM
kwm retitled this revision from to Update libgit2 to 0.22.x..
kwm updated this object.
kwm edited the test plan for this revision. (Show Details)
kwm added reviewers: koobs, swills.
kwm added a comment.May 6 2015, 8:42 PM

To be clear, I would like help with making sure the py-pygit2 and rubygem port install/work fine.

mmoll added a subscriber: mmoll.May 6 2015, 10:40 PM

Tested with rubygem-rugged, I can browse around in a git repo on irb just fine.
At least for me the rugged 0.21 version we're having in ports right now is showing the same QA problems.

koobs added a reviewer: wg.May 11 2015, 9:18 AM
koobs requested changes to this revision.May 11 2015, 9:35 AM
koobs edited edge metadata.

pygit2 test suite runs clean:

Ran 229 tests in 13.441s - OK

I added the following to the port for future testers & QA:

 USE_PYTHON=    autoplist distutils
 MAKE_ENV=      LIBGIT2=${LOCALBASE}

+regression-test: build
+       @cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test
+
 .include <bsd.port.mk>

Shared libraries need to be stripped:

Warning: 'lib/python2.7/site-packages/_pygit2.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/python2.7/site-packages/pygit2_cffi_4091df83x5470904.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
This revision now requires changes to proceed.May 11 2015, 9:35 AM
kwm updated this revision to Diff 5323.May 11 2015, 10:46 AM
kwm edited edge metadata.

py-pygit2: Add test command and strip .so files.

koobs accepted this revision.May 11 2015, 10:48 AM
koobs edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 11 2015, 10:48 AM
swills accepted this revision.May 11 2015, 11:45 AM
swills edited edge metadata.

The changes to rubygem-rugged look fine to me.

kwm closed this revision.May 11 2015, 9:01 PM

Committed in revision 386103.