net-mgmt/librenms: add Dispatch Service option to

[dvl]

Summary

Taken from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246105

[dvl]

Add updating entry
create empty log file
Improve pkg-message

[driesm]

Thanks for your work on this Dan! I left a rough review, although most of them are easily fixable. Looking good so far! Looking forward seeing this landed :-).

net-mgmt/librenms/Makefile

6

This was my bad in the original diff against 1.62, prevision was reset to 0 when you updated to 1.63, so PORTREVISION=1 should be fine :-)

213

Will this not have the unwanted behavior that the logfile is part of the port, eg. when uninstalling the port it will delete the logfile with it (emty or not)? Another option is to check for both librenms.log and librenms-service.log existence in a subfunction in the rc.script and create them when they do not exist with install.

something like:
start_precmd=librenms_precmd
librenms_precmd()
{
     [ -f /var/log/$name/$name-service.log ] || install -g ${%%GROUP%%} -o ${%%USER%%} -m 644 /var/log/$name/$name-service.log
     [ -f /var/log/$name/$name.log ] || install -g ${%%GROUP%%} -o ${%%USER%%} -m 644 /var/log/$name/$name.log
}

net-mgmt/librenms/files/librenms.in

40

/usr/local/librenms/librenms-service.py should not be hard coded, but substituted with PREFIX or WWWDIR for non default PREFIX variables.

net-mgmt/librenms/files/pkg-message.in

23

PYSERVER/s/PYSERVICE

53

Should probably mention that the port needs to be rebuild with PYSERVICE option?

77

PYSERVER/s/PYSERVICE

125

the the / s / the

[dvl]

Adding in recommended changes

net-mgmt/librenms/Makefile

6

I keep bumping PORTREVISION so it builds and installs with ease.

net-mgmt/librenms/files/pkg-message.in

53

• compile with PYSERVICE enabled and PYPOLLER disabled

[driesm]

For whatever my approval is worth :-)

[driesm]

This landed in r533804, thanks Dan!