new port: security/rubyauth-omniauth-bitbucket
ClosedPublic
Actions

Authored by mmoll on May 6 2015, 7:52 PM.

Details

Reviewers

swills
mat

Summary

Taken from PR 199780 with minor modifications.
Proposed commit message:

new port: security/omniauth-bitbucket

Ruby gem to add an OmniAuth strategy for Atlassian Bitbucket.

WWW: https://github.com/sishen/omniauth-bitbucket

PR:		199780
Submitted by:	Torsten Zuehlsdorff <ports@toco-domains.de>
Approved by:	swills (mentor), mat (mentor)

Test Plan

http://space.kvedulv.de/FreeBSD/rubygem-omniauth-bitbucket-0.0.2.log

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

mmoll updated this revision to Diff 5238.May 6 2015, 7:52 PM

mmoll retitled this revision from to new port: security/omniauth-bitbucket.

mmoll updated this object.

mmoll edited the test plan for this revision. (Show Details)

mmoll added reviewers: swills, mat.

mat added inline comments.May 6 2015, 8:52 PM

security/rubygem-omniauth-bitbucket/pkg-descr
2	The pkg-descr file should not quote the COMMENT line of the makefile verbatim, it should be more verbose.

extend pkg-descr

mmoll added inline comments.May 6 2015, 9:38 PM

security/rubygem-omniauth-bitbucket/pkg-descr
1	Sure, but unfortunately there's not that much to write... In Debian all the rubygem-omniauth-* packages have some general text about rubygem-omniauth at the top and then something like "This package implements the oauth strategy for Bitbucket.", but I'm unsure if that's better.

I think the title of this review is wrong, it lacks "rubygem-". I'm OK with the content of the pkg-descr. The category change seems correct and the port content seems fine.

mmoll retitled this revision from new port: security/omniauth-bitbucket to new port: security/rubyauth-omniauth-bitbucket.May 7 2015, 2:24 PM

mmoll edited edge metadata.

mat accepted this revision.May 9 2015, 4:03 PM

mat edited edge metadata.

This revision is now accepted and ready to land.May 9 2015, 4:03 PM

committed in rP385903