Page MenuHomeFreeBSD

editors/emacs: Add optional workaround for Fcitx input method
ClosedPublic

Authored by jrm on Feb 17 2020, 3:00 AM.

Details

Summary
  • Don't forget to add 'Approved by:' and 'Differential Revision:' **

PR: 242012
Submitted by:
Reported by:

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jrm created this revision.Feb 17 2020, 3:00 AM

I have not built it, but the patch seems to apply fine (including with canna flavour). Should we add an implicit dependency on X11 for FCITXPATCH option, as patch is useless in nox flavour, AFAICS ?

ashish added inline comments.Feb 17 2020, 10:17 AM
editors/emacs/Makefile
115 ↗(On Diff #68436)

Maybe we can add FCITXPATCH here ?

jrm updated this revision to Diff 68451.Feb 17 2020, 11:12 AM

Exclude FCITXPATCH when flavor is nox

jrm marked an inline comment as done.Feb 17 2020, 11:13 AM
jrm added inline comments.
editors/emacs/Makefile
115 ↗(On Diff #68436)

I think you're right. Done.

ashish accepted this revision.Feb 18 2020, 7:45 AM

Looks good to me.

Thank you!

This revision is now accepted and ready to land.Feb 18 2020, 7:45 AM
This revision was automatically updated to reflect the committed changes.
jrm marked an inline comment as done.