I have not built it, but the patch seems to apply fine (including with canna flavour). Should we add an implicit dependency on X11 for FCITXPATCH option, as patch is useless in nox flavour, AFAICS ?

ashish added inline comments.Feb 17 2020, 10:17 AM

editors/emacs/Makefile
115 ↗	(On Diff #68436)	Maybe we can add `FCITXPATCH` here ?

Exclude FCITXPATCH when flavor is nox

Harbormaster completed remote builds in B29443: Diff 68451.Feb 17 2020, 11:12 AM

jrm marked an inline comment as done.Feb 17 2020, 11:13 AM

jrm added inline comments.

editors/emacs/Makefile
115 ↗	(On Diff #68436)	I think you're right. Done.

Looks good to me.

Thank you!

This revision is now accepted and ready to land.Feb 18 2020, 7:45 AM

Closed by commit rP526478: editors/emacs: Add optional workaround for Fcitx input method (authored by jrm). · Explain WhyFeb 18 2020, 10:57 PM

This revision was automatically updated to reflect the committed changes.

jrm marked an inline comment as done.

jrm added a commit: rP526478: editors/emacs: Add optional workaround for Fcitx input method.

Revision Contents
Changeset List

Path

Size

head/

editors/

emacs/

Makefile

19 lines

files/

extra-patch-src_xfns.c

12 lines

Diff 68509

View Options

head/editors/emacs/Makefile

View Options

head/editors/emacs/files/extra-patch-src_xfns.c

editors/emacs: Add optional workaround for Fcitx input methodClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 68509

head/editors/emacs/Makefile

head/editors/emacs/files/extra-patch-src_xfns.c

editors/emacs: Add optional workaround for Fcitx input method
ClosedPublic
Actions

Revision Contents
Changeset List