Page MenuHomeFreeBSD
Differential D2338

readelf: avoid division by zero for files with invalid sh_entsize
ClosedPublic
Actions

Authored by emaste on Apr 20 2015, 8:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 6:38 AM
Unknown Object (File)
Fri, Apr 26, 6:23 AM
Unknown Object (File)
Tue, Apr 23, 5:34 AM
Unknown Object (File)
Apr 14 2024, 5:28 PM
Unknown Object (File)
Apr 8 2024, 1:56 PM
Unknown Object (File)
Jan 2 2024, 6:16 AM
Unknown Object (File)
Jan 2 2024, 6:16 AM
Unknown Object (File)
Dec 23 2023, 9:06 AM
View All 63 Files
Subscribers
brooks
freebsd-toolchain-list

Details

Reviewers
brooks
Commits
rS285845: readelf: avoid division by zero on section entry size
Summary

Variations reported in:
https://sourceforge.net/p/elftoolchain/tickets/439
https://sourceforge.net/p/elftoolchain/tickets/444
https://sourceforge.net/p/elftoolchain/tickets/445
https://sourceforge.net/p/elftoolchain/tickets/467

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 4930.Apr 20 2015, 8:43 PM
emaste retitled this revision from to readelf: avoid division by zero for files with invalid sh_entsize.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a subscriber: Unknown Object (MLST).
brooks accepted this revision.Apr 20 2015, 8:50 PM
brooks added a reviewer: brooks.
brooks added a subscriber: brooks.

Looks good to me.

This revision is now accepted and ready to land.Apr 20 2015, 8:50 PM
emaste updated this revision to Diff 7069.Jul 19 2015, 11:13 AM
emaste edited edge metadata.

Add a get_ent_count helper to check for 0 entsize instead of expanding the check inline everywhere.

This revision now requires review to proceed.Jul 19 2015, 11:13 AM
brooks added a comment.Jul 23 2015, 5:32 PM

Is this still live?

emaste added a comment.Jul 23 2015, 5:47 PM

Yes - sorry for the delay. I realized I had a newer implementation that factored the divide-by-zero checks into a helper function, and uploaded the new diff a few days ago.

brooks accepted this revision.Jul 23 2015, 7:32 PM
brooks edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Jul 23 2015, 7:32 PM
Closed by commit rS285845: readelf: avoid division by zero on section entry size (authored by emaste). · Explain WhyJul 24 2015, 6:01 PM
This revision was automatically updated to reflect the committed changes.
emaste added a comment.Jul 27 2015, 6:57 PM

Upstream commit here: https://sourceforge.net/p/elftoolchain/code/3227/

Revision Contents
Changeset List

PathSize
contrib/
elftoolchain/
readelf/
62 lines
head/
contrib/
elftoolchain/
readelf/
62 lines

Diff 7269

View Options

contrib/elftoolchain/readelf/readelf.c

Loading...
View Options

head/contrib/elftoolchain/readelf/readelf.c

Loading...