Page MenuHomeFreeBSD

security/libgpg-error: Remove gmake dependency, MAKE_JOBS_UNSAFE and add "make test"
ClosedPublic

Authored by daniel.engberg.lists_pyret.net on Sat, Jan 11, 4:38 PM.

Details

Summary

Remove gmake dependency, MAKE_JOBS_UNSAFE and add "make test" functionality

Test Plan

make test tested on 13-CURRENT r356392 (AMD64)
Poudriere log{F6039011}

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

daniel.engberg.lists_pyret.net retitled this revision from security/libgpg-error: Remove gmake dependency and add "make test" to security/libgpg-error: Remove gmake dependency, MAKE_JOBS_UNSAFE and add "make test".Sat, Jan 11, 4:46 PM
daniel.engberg.lists_pyret.net edited the summary of this revision. (Show Details)

Hi,

Thanks for the patch. Just to let you know, I'm testing this changes (and then will switch to a similar libtasn1 patch).
It's better to test some more combinations of versions/arches to make sure that the changes are safe, esp. the MAKE_JOBS_UNSAFE part, so it'll take some time.

Roman

Hi,

Thanks for your time! I agree that we should try to avoid unnecessary breakage.
I gave it a quick spin on my aarch64 box (4 cores) running 13-CURRENT (r356372) and it built successfully if it helps.

novel accepted this revision.Wed, Jan 15, 3:50 PM
This revision is now accepted and ready to land.Wed, Jan 15, 3:50 PM