Differential D23134

security/libgpg-error: Remove gmake dependency, MAKE_JOBS_UNSAFE and add "make test"
ClosedPublic
Actions

Authored by diizzy on Jan 11 2020, 4:38 PM.

Details

Reviewers

novel

Commits

rP523119: security/libgpg-error: drop gmake, MAKE_JOBS_UNSAFE, add "make test"

Summary

Remove gmake dependency, MAKE_JOBS_UNSAFE and add "make test" functionality

Test Plan

make test tested on 13-CURRENT r356392 (AMD64)
Poudriere log{F6039011}

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

diizzy created this revision.Jan 11 2020, 4:38 PM

Herald added a subscriber: mat. · View Herald TranscriptJan 11 2020, 4:38 PM

diizzy retitled this revision from security/libgpg-error: Remove gmake dependency and add "make test" to security/libgpg-error: Remove gmake dependency, MAKE_JOBS_UNSAFE and add "make test".Jan 11 2020, 4:46 PM

diizzy edited the summary of this revision. (Show Details)

Hi,

Thanks for the patch. Just to let you know, I'm testing this changes (and then will switch to a similar libtasn1 patch).
It's better to test some more combinations of versions/arches to make sure that the changes are safe, esp. the MAKE_JOBS_UNSAFE part, so it'll take some time.

Roman

Hi,

Thanks for your time! I agree that we should try to avoid unnecessary breakage.
I gave it a quick spin on my aarch64 box (4 cores) running 13-CURRENT (r356372) and it built successfully if it helps.

novel accepted this revision.Jan 15 2020, 3:50 PM

This revision is now accepted and ready to land.Jan 15 2020, 3:50 PM

Closed by commit rP523119: security/libgpg-error: drop gmake, MAKE_JOBS_UNSAFE, add "make test" (authored by novel). · Explain WhyJan 15 2020, 3:53 PM

This revision was automatically updated to reflect the committed changes.

novel added a commit: rP523119: security/libgpg-error: drop gmake, MAKE_JOBS_UNSAFE, add "make test".