Page MenuHomeFreeBSD

security/libgpg-error: Remove gmake dependency, MAKE_JOBS_UNSAFE and add "make test"
ClosedPublic

Authored by diizzy on Jan 11 2020, 4:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 11 2024, 5:10 PM
Unknown Object (File)
Feb 11 2024, 5:10 PM
Unknown Object (File)
Feb 11 2024, 5:10 PM
Unknown Object (File)
Feb 11 2024, 4:59 PM
Unknown Object (File)
Dec 20 2023, 1:14 AM
Unknown Object (File)
Dec 4 2023, 2:14 AM
Unknown Object (File)
Sep 7 2023, 3:27 AM
Unknown Object (File)
Sep 7 2023, 3:27 AM
Subscribers

Details

Summary

Remove gmake dependency, MAKE_JOBS_UNSAFE and add "make test" functionality

Test Plan

make test tested on 13-CURRENT r356392 (AMD64)
Poudriere log{F6039011}

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

diizzy retitled this revision from security/libgpg-error: Remove gmake dependency and add "make test" to security/libgpg-error: Remove gmake dependency, MAKE_JOBS_UNSAFE and add "make test".Jan 11 2020, 4:46 PM
diizzy edited the summary of this revision. (Show Details)

Hi,

Thanks for the patch. Just to let you know, I'm testing this changes (and then will switch to a similar libtasn1 patch).
It's better to test some more combinations of versions/arches to make sure that the changes are safe, esp. the MAKE_JOBS_UNSAFE part, so it'll take some time.

Roman

Hi,

Thanks for your time! I agree that we should try to avoid unnecessary breakage.
I gave it a quick spin on my aarch64 box (4 cores) running 13-CURRENT (r356372) and it built successfully if it helps.

This revision is now accepted and ready to land.Jan 15 2020, 3:50 PM