Unbreak build of archivers/file-roller on FreeBSD 8.4
ClosedPublic
Actions

Authored by truckman on Apr 10 2015, 11:41 PM.

Details

Reviewers

koobs
kwm
mat

Commits

rP383819: n FreeBSD 8 the name of the mtime member of struct stat was st_mtimespec.

Summary

In FreeBSD 8.4 this member of struct stat is named st_mtimespec,
instead of st_mtim. In the early days of FreeBSD 9 (after the
branch but before 9.0-RELEASE), it was renamed to st_mtim in src
rev r205792 for POSIX 2008 compliance. This change was never
merged back to 8-STABLE. There was no corresponding bump of
__FreeBSD_version, but the change happened between 900010 and 900011.

Use the old name when building on FreeBSD 8.4.

Test Plan

Build on FreeBSD 8.4, 9.3, 10.1, and 11.0

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

truckman updated this revision to Diff 4789.Apr 10 2015, 11:41 PM

truckman retitled this revision from to Unbreak build of archivers/file-roller on FreeBSD 8.4.

truckman updated this object.

truckman edited the test plan for this revision. (Show Details)

truckman added reviewers: mat, koobs.

truckman added a subscriber: gnome.

I feel the #if __FreeBSD_version guards should be more expanded. however since this is only for 8.4 I'm not bothered by the lack of it.

This revision is now accepted and ready to land.Apr 11 2015, 8:14 AM

mat accepted this revision.Apr 11 2015, 8:35 AM

mat edited edge metadata.

Closed by commit rP383819 (authored by @truckman).

Revision Contents
Changeset List

Path

Size

head/

archivers/

file-roller/

Makefile

4 lines

files/

patch-src_fr-command-patch-src_fr-command-lrzip.c

14 lines

Diff 4794

View Options

head/archivers/file-roller/Makefile