Implement a system-wide limit or da and ada devices for delete.
ClosedPublic
Actions

Authored by imp on Dec 14 2019, 12:04 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 10, 5:17 AM

	Unknown Object (File)
	Sat, May 9, 3:18 PM

	Unknown Object (File)
	Fri, May 8, 8:18 PM

	Unknown Object (File)
	Sun, May 3, 6:04 PM

	Unknown Object (File)
	Sat, May 2, 11:52 PM

	Unknown Object (File)
	Thu, Apr 30, 2:47 PM

	Unknown Object (File)
	Thu, Apr 30, 3:16 AM

	Unknown Object (File)
	Sun, Apr 26, 12:35 AM

View All Files

Subscribers

None

Details

Reviewers

scottl

Commits

rS355813: Implement a system-wide limit or da and ada devices for delete.

Summary

Excesively large TRIMs can result in timeouts, which cause big
problems. Limit trims to 1GB to mititgate these issues.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Dec 14 2019, 12:04 AM

Harbormaster completed remote builds in B28144: Diff 65639.Dec 14 2019, 12:04 AM

imp added a reviewer: scottl.Dec 14 2019, 12:04 AM

I oscillate back and forth as to setting the limit to -1 and having that mean 'no limit beyond the drive itself's limit'

scottl accepted this revision.Dec 14 2019, 12:13 AM

This revision is now accepted and ready to land.Dec 14 2019, 12:13 AM

Closed by commit rS355813: Implement a system-wide limit or da and ada devices for delete. (authored by imp). · Explain WhyDec 16 2019, 6:16 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rS355813: Implement a system-wide limit or da and ada devices for delete..

Revision Contents
Changeset List

Path

Size

head/

sys/

cam/

ata/

ata_da.c

10 lines

scsi/

scsi_da.c

12 lines

Diff 65711

View Options

head/sys/cam/ata/ata_da.c