Page MenuHomeFreeBSD
Differential D22696

Use 4 byte stack alignment instead of 8 byte.
ClosedPublic
Actions

Authored by jhb on Dec 5 2019, 9:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 28, 2:04 PM
Unknown Object (File)
Thu, Nov 27, 7:58 PM
Unknown Object (File)
Tue, Nov 25, 11:56 PM
Unknown Object (File)
Thu, Nov 13, 8:45 PM
Unknown Object (File)
Thu, Nov 13, 4:27 PM
Unknown Object (File)
Thu, Nov 13, 11:12 AM
Unknown Object (File)
Oct 30 2025, 12:43 AM
Unknown Object (File)
Oct 21 2025, 9:51 PM
View All 40 Files
Subscribers
None

Details

Reviewers
kib
Commits
rS355569: Use 4 byte stack alignment instead of 8 byte.
Summary

This was an old bug prior to r355373 and mostly harmless as it would
waste at most a handful of bytes on the stack.

Test Plan
  • compiled only

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 27990
Build 26151: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 5 2019, 9:52 PM
Harbormaster completed remote builds in B27990: Diff 65282.Dec 5 2019, 9:52 PM
kib accepted this revision.Dec 6 2019, 1:04 PM
kib added inline comments.
sys/amd64/linux32/linux32_sysvec.c
751

Does linux need canary in auxv ?

This revision is now accepted and ready to land.Dec 6 2019, 1:04 PM
jhb marked an inline comment as done.Dec 9 2019, 6:33 PM
jhb added inline comments.
sys/amd64/linux32/linux32_sysvec.c
229

Linux uses the canary here for AT_RANDOM.

jhb closed this revision.Dec 9 2019, 11:36 PM
jhb added a commit: rS355569: Use 4 byte stack alignment instead of 8 byte..

Revision Contents
Changeset List

PathSize
sys/
amd64/
linux32/
8 lines

Diff 65282

View Options

sys/amd64/linux32/linux32_sysvec.c

Loading...