french/eficas: Drop dependency on py-qt4-assistant.
ClosedPublic
Actions

Authored by rakuco on Jun 15 2014, 3:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	May 19 2024, 10:58 PM

	Unknown Object (File)
	Apr 8 2024, 7:46 AM

	Unknown Object (File)
	Apr 8 2024, 7:24 AM

	Unknown Object (File)
	Jan 17 2024, 5:05 PM

	Unknown Object (File)
	Nov 24 2023, 11:22 PM

	Unknown Object (File)
	Nov 6 2023, 7:14 PM

	Unknown Object (File)
	Oct 24 2023, 9:33 AM

	Unknown Object (File)
	Aug 26 2023, 1:10 PM

View All 33 Files

Subscribers

None

Details

Reviewers

thierry
rakuco

Summary

py-qt4-assistant should have been removed years ago, and french/eficas is the last port that depends on it. It turns out that version 7.3.0.1 does not depend on it anymore -- the code that used to import and run it in the PyQt UI has been replaced and just invokes xdg-open now.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rakuco updated this revision to Diff 398.Jun 15 2014, 3:59 PM

rakuco retitled this revision from to french/eficas: Drop dependency on py-qt4-assistant..

rakuco updated this object.

rakuco added a reviewer: thierry.

Thanks for the notification!
Since xdg-open is used, I'd prefer to add it as a dependency: see the attached patch.

eficas.diff668 BDownload

You're totally right, sorry for the oversight. Who should commit your patch version then?

As you like!
Please go, or let me know if you prefer me to commit.

Landed in r357906, thank you. I wonder if "Accept Revision" is enough to close this review request...

This revision is now accepted and ready to land.Jun 15 2014, 5:25 PM

OK, "Close Revision" is what I'm looking for.

Revision Contents
Changeset List

Path

Size

french/

eficas/

Makefile

4 lines

Diff 398

View Options

french/eficas: Drop dependency on py-qt4-assistant.ClosedPublicActions