Page MenuHomeFreeBSD

Mk/bsd.sanity.mk: Whitelist GO_TEST_TARGET options helper lookalike
AbandonedPublic

Authored by tobik on Thu, Nov 21, 9:31 AM.

Details

Reviewers
dmgk
mat
Group Reviewers
portmgr
O5: Ports Framework(Owns No Changed Paths)
Summary

There might be false positives if a port has a GO option and also
USES=go after the introduction of GO_TEST_TARGET in rP517831.

/!\ knot-resolver-4.1.0_2: Makefile errors /!\

The following options helpers are incorrectly set after bsd.port.options.mk
and are ineffective: GO_TEST_TARGET

*** Error code 1

Alternatively, we could rename GO_TEST_TARGET to something else
that does not overlap with an options helper since it is still new.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27677
Build 25878: arc lint + arc unit

Event Timeline

tobik created this revision.Thu, Nov 21, 9:31 AM
Herald added 1 blocking reviewer(s): portmgr. ยท View Herald TranscriptThu, Nov 21, 9:31 AM
dmgk accepted this revision.Thu, Nov 21, 12:33 PM

I'm ok either way, thanks for catching this.

tobik abandoned this revision.Tue, Dec 3, 1:35 PM

No point to this review after rP518928.