Page MenuHomeFreeBSD

*/gstreamer*: Prevent false QA warnings about missing USES

Authored by tobik on Nov 16 2019, 7:06 AM.



This is to prevent bogus QA warnings like the following in GStreamer ports

Using USE_XORG alone is deprecated, please use USES=xorg

gstreamer1?-plugins/Makefile.common can under some circumstances create empty USE_XORG, USE_GNOME, etc. which trigger the warnings.

gstreamer-plugins-good triggers the USE_XORG warning because USES is overwritten again after including the master Makefile.

gstreamer-plugin-sdl was missing USES=sdl.

Test Plan

A test build of all */gstreamer* ports was fine on 12.0 amd64.

Diff Detail

rP FreeBSD ports repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tobik created this revision.Nov 16 2019, 7:06 AM
tobik edited the test plan for this revision. (Show Details)Nov 16 2019, 7:52 AM
kwm accepted this revision.Nov 16 2019, 3:17 PM
kwm added a subscriber: kwm.

Macro lgtm:

This revision is now accepted and ready to land.Nov 16 2019, 3:17 PM
This revision was automatically updated to reflect the committed changes.