Page MenuHomeFreeBSD
Differential D22406

*/gstreamer*: Prevent false QA warnings about missing USES
ClosedPublic
Actions

Authored by tobik on Nov 16 2019, 7:06 AM.

Details

Reviewers
kwm
Group Reviewers
multimedia
Commits
rP517751: */gstreamer*: Prevent false QA warnings about missing USES
Summary

This is to prevent bogus QA warnings like the following in GStreamer ports

Using USE_XORG alone is deprecated, please use USES=xorg

gstreamer1?-plugins/Makefile.common can under some circumstances create empty USE_XORG, USE_GNOME, etc. which trigger the warnings.

gstreamer-plugins-good triggers the USE_XORG warning because USES is overwritten again after including the master Makefile.

gstreamer-plugin-sdl was missing USES=sdl.

Test Plan

A test build of all */gstreamer* ports was fine on 12.0 amd64.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tobik created this revision.Nov 16 2019, 7:06 AM
tobik edited the test plan for this revision. (Show Details)Nov 16 2019, 7:52 AM
kwm accepted this revision.Nov 16 2019, 3:17 PM
kwm added a subscriber: kwm.

Macro lgtm:

This revision is now accepted and ready to land.Nov 16 2019, 3:17 PM
Closed by commit rP517751: */gstreamer*: Prevent false QA warnings about missing USES (authored by tobik). · Explain WhyNov 16 2019, 3:20 PM
This revision was automatically updated to reflect the committed changes.
tobik added a commit: rP517751: */gstreamer*: Prevent false QA warnings about missing USES.

Revision Contents
Changeset List

Diff 64446

View Options

head/multimedia/gstreamer-plugins-good/Makefile

Loading...
View Options

head/multimedia/gstreamer-plugins/Makefile

Loading...
View Options

head/multimedia/gstreamer-plugins/Makefile.common

Loading...
View Options

head/multimedia/gstreamer1-plugins/Makefile.common

Loading...