audio/pianobar: Cleanup Makefile

[diizzy]

Summary

Add localbase and remove unneeded additional arguments and variables
Upstreamed changed backend to ffmpeg back in 2014.
Commit: c872f00508ce4afe3b8ec863b23595c31fd8b4be

Test Plan

Tested with poudriere, log attached{F5827544}

[diizzy]

@jhixson
Friendly ping

[mat]

Where did the -std=c99 go?

[diizzy]

Pianobar sets it, sorry for not mentioning that.

head/audio/pianobar/Makefile

 #                               Requires /usr to be mounted.
 #
 #       ${name}_groups  n       Comma separated list of supplementary groups
 #                               to run the chrooted ${command} with.
 #                               Requires /usr to be mounted.
 #
 #       ${name}_prepend n       Command added before ${command}.
 #
+#       ${name}_login_class n   Login class to use, else "daemon".
+#
 #       ${rc_arg}_cmd   n       If set, use this as the method when invoked;
 #                               Otherwise, use default command (see below)
 #
 #       ${rc_arg}_precmd n      If set, run just before performing the
 #                               ${rc_arg}_cmd method in the default
 #                               operation (i.e, after checking for required
 #                               bits and process (non)existence).
 #                               If this completes with a non-zero exit code,
if [ -n "$flags" ]; then      # allow override from environment
                 rc_flags=$flags
         else
                 eval rc_flags=\$${name}_flags
         fi
         eval _chdir=\$${name}_chdir     _chroot=\$${name}_chroot \
             _nice=\$${name}_nice        _user=\$${name}_user \
             _group=\$${name}_group      _groups=\$${name}_groups \
             _fib=\$${name}_fib          _env=\$${name}_env \
-            _prepend=\$${name}_prepend
+            _prepend=\$${name}_prepend  _login_class=\${${name}_login_class:-daemon}
 
         if [ -n "$_user" ]; then      # unset $_user if running as that user
                 if [ "$_user" = "$(eval $IDCMD)" ]; then
                         unset _user
                 fi
         fi
 
         [ -z "$autoboot" ] && eval $_pidcmd   # determine the pid if necessary
$command $rc_flags $command_args"
                                                 _doit="sh -c \"$_doit\""
                                         fi
                                         _doit="nice -n $_nice $_doit"
                                 fi
                                 if [ -n "$_prepend" ]; then
                                         _doit="$_prepend $_doit"
                                 fi
                         fi
+
+                                        # Prepend default limits
+                        _doit="limits -C $_login_class $_doit"
 
                                         # run the full command
                                         #
                         if ! _run_rc_doit "$_doit"; then
                                 warn "failed to start ${name}"
                                 return 1
                         fi