Page MenuHomeFreeBSD
Differential D22143

print/scribus-devel: fix build on GCC architectures
ClosedPublic
Actions

Authored by pkubaj on Oct 24 2019, 4:35 PM.
Tags
None
Referenced Files
F167658165: D22143.diff
Sun, Aug 23, 2:33 PM
F167653523: D22143.id.diff
Sun, Aug 23, 1:25 PM
Unknown Object (File)
Sun, Aug 23, 12:18 AM
Unknown Object (File)
Sat, Aug 8, 7:55 PM
Unknown Object (File)
Fri, Aug 7, 8:58 PM
Unknown Object (File)
Fri, Aug 7, 6:18 PM
Unknown Object (File)
Thu, Aug 6, 9:34 AM
Unknown Object (File)
Thu, Aug 6, 7:41 AM
View All Files
Subscribers
None

Details

Reviewers
linimon
mat
tcberner
Commits
rP517142: print/scribus-devel: fix build on GCC architectures
Summary

isnan() causes error with GCC, use std::isnan().

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pkubaj created this revision.Oct 24 2019, 4:35 PM
Harbormaster completed remote builds in B27203: Diff 63639.Oct 24 2019, 4:35 PM
tcberner accepted this revision.Nov 9 2019, 6:46 PM

Looks good to me -- under the assumption that you verified, that it still works on non-gcc architectures.

This revision is now accepted and ready to land.Nov 9 2019, 6:46 PM
Closed by commit rP517142: print/scribus-devel: fix build on GCC architectures (authored by pkubaj). · Explain WhyNov 9 2019, 7:51 PM
This revision was automatically updated to reflect the committed changes.
pkubaj added a commit: rP517142: print/scribus-devel: fix build on GCC architectures.

Revision Contents
Changeset List

PathSize
head/
print/
scribus-devel/
files/
11 lines

Diff 64123

View Options

head/print/scribus-devel/files/patch-scribus_third__party_lib2geom_isnan.h

Loading...