ping: Use setitimer(2) instead of obsoleted alarm(3)
ClosedPublic
Actions

Authored by jansucan on Oct 22 2019, 7:24 AM.

Details

Reviewers

asomers

Commits

rS355106: ping, ping6: Use setitimer(2) instead of obsolete alarm(3)

Summary

Use setitimer(2) instead of obsoleted alarm(3)

Submitted by: Ján Sučan <sucanjan@gmail.com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jansucan created this revision.Oct 22 2019, 7:24 AM

Harbormaster completed remote builds in B27145: Diff 63529.Oct 22 2019, 7:24 AM

What about ping6.c? It has a similar invocation of alarm.

sbin/ping/ping.c
511 ↗	(On Diff #63529)	The other fields of itv are set to stack garbage. You should zero them.

This revision now requires changes to proceed.Nov 13 2019, 3:32 PM

Use setitimer(2) instead of obsoleted alarm(3)

Submitted by: Ján Sučan <sucanjan@gmail.com>

Harbormaster completed remote builds in B27509: Diff 64318.Nov 14 2019, 1:58 PM

I did the same for ping6. I was not sure whether to do that in this diff or in a separate one.

sbin/ping/ping.c
511 ↗	(On Diff #63529)	Thanks. Fixed.

LGTM. The extra braces you added in order to create scope for the itv variable are stylistically contentious. Some people would disagree with that, because it's not commonly done. But I happen to like that technique myself; no reason for itv to have more scope than necessary.

This revision is now accepted and ready to land.Nov 26 2019, 5:02 AM

Closed by commit rS355106: ping, ping6: Use setitimer(2) instead of obsolete alarm(3) (authored by asomers). · Explain WhyNov 26 2019, 5:06 AM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS355106: ping, ping6: Use setitimer(2) instead of obsolete alarm(3).

Herald added a subscriber: imp. · View Herald TranscriptNov 26 2019, 5:06 AM