Page MenuHomeFreeBSD
Differential D21996

Mk/bsd.port.mk: don't switch to ld.bfd on powerpc64 with clang
ClosedPublic
Actions

Authored by pkubaj on Oct 12 2019, 4:29 PM.
Tags
None
Referenced Files
F103278398: D21996.id63197.diff
Fri, Nov 22, 11:57 PM
F103252621: D21996.id63197.diff
Fri, Nov 22, 4:08 PM
F103246508: D21996.diff
Fri, Nov 22, 2:34 PM
Unknown Object (File)
Thu, Nov 21, 2:13 PM
Unknown Object (File)
Wed, Nov 20, 11:51 AM
Unknown Object (File)
Tue, Nov 19, 8:21 PM
Unknown Object (File)
Tue, Nov 19, 12:19 AM
Unknown Object (File)
Fri, Nov 15, 11:16 PM
View All 89 Files
Subscribers
None

Details

Reviewers
linimon
mat
tcberner
Group Reviewers
portmgr
O5: Ports Framework
Commits
rP514354: Mk/bsd.port.mk: use GNU LD from ports on powerpc64 elfv2 when GNU LD is required
Summary

With powerpc64 soon switching to clang, it doesn't make sense to use base ld.bfd when LLD_UNSAFE is defined.

Accepted by portmgr in PR 239743

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pkubaj created this revision.Oct 12 2019, 4:29 PM
Owners added a reviewer: O5: Ports Framework.Oct 12 2019, 4:29 PM
Herald added a reviewer: portmgr. · View Herald TranscriptOct 12 2019, 4:29 PM
Harbormaster completed remote builds in B27002: Diff 63185.Oct 12 2019, 4:29 PM
pkubaj removed reviewers: O5: Ports Framework, portmgr.Oct 12 2019, 4:30 PM
Herald added a reviewer: portmgr. · View Herald TranscriptOct 12 2019, 4:30 PM
pkubaj removed a reviewer: portmgr.Oct 12 2019, 4:30 PM
Herald added a reviewer: portmgr. · View Herald TranscriptOct 12 2019, 4:30 PM
pkubaj added a comment.Oct 12 2019, 4:30 PM

Looks like phabricator requires portmgr in reviewers, but it was actually already accepted by portmgr.

tcberner accepted this revision.Oct 12 2019, 7:51 PM

Lgtm. Decide for yourself whether you want to wait for an explicit approval by portmgr.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 12 2019, 8:49 PM
Closed by commit rP514354: Mk/bsd.port.mk: use GNU LD from ports on powerpc64 elfv2 when GNU LD is required (authored by pkubaj). · Explain Why
This revision was automatically updated to reflect the committed changes.
pkubaj added a commit: rP514354: Mk/bsd.port.mk: use GNU LD from ports on powerpc64 elfv2 when GNU LD is required.
Owners added a reviewer: O5: Ports Framework.Oct 12 2019, 8:49 PM

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
5 linesO5: Ports Framework

Diff 63197

View Options

head/Mk/bsd.port.mk

Loading...