Page MenuHomeFreeBSD
Differential D21544

Reduce code duplication by calling fetch target
ClosedPublic
Actions

Authored by bapt on Sep 6 2019, 8:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 9, 10:42 AM
Unknown Object (File)
Sat, Aug 8, 10:05 AM
Unknown Object (File)
Fri, Aug 7, 4:52 PM
Unknown Object (File)
Wed, Jul 22, 7:58 PM
Unknown Object (File)
Wed, Jul 22, 11:14 AM
Unknown Object (File)
Mon, Jul 20, 1:04 AM
Unknown Object (File)
Jun 28 2026, 2:36 PM
Unknown Object (File)
Jun 23 2026, 12:21 AM
View All Files
Subscribers
mat

Details

Reviewers
None
Group Reviewers
portmgr
Commits
rP513191: Reduce code duplication by calling fetch target
Summary

when converting the do-fetch target to proper scripting
we lost the ability to overwrite do-fetch when running make makesum.
as reported here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215530

Let's call again do-fetch directly instead of duplicating its content

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt created this revision.Sep 6 2019, 8:20 AM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptSep 6 2019, 8:20 AM
Herald added a subscriber: mat. · View Herald Transcript
Harbormaster completed remote builds in B26302: Diff 61718.Sep 6 2019, 8:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 29 2019, 4:15 AM
Closed by commit rP513191: Reduce code duplication by calling fetch target (authored by bapt). · Explain Why
This revision was automatically updated to reflect the committed changes.
bapt added a commit: rP513191: Reduce code duplication by calling fetch target.
mat added a comment.EditedSep 29 2019, 11:46 AM
This comment has been deleted.
head/Mk/bsd.port.mk
3876

Shouldn't it call do-fetch? It is what the commit message says.

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
16 linesO5: Ports Framework

Diff 62697

View Options

head/Mk/bsd.port.mk

Loading...