net/htpdate: Fix the service script

[0mp]

Summary

net/htpdate: Fix the service script

For some reason the PID written to the pidfile by htpdate does not match its
actual PID, which renders the standard PID-handling mechanism of rc.subr(8)
useless.

As a solution, depend only on the process name to figure out the PID of the
running process.

NB: the old pidfile has to be removed before starting htpdate. Otherwise, the
program complains about the pidfile already existing (which htpdate interprets
as another instance of htpdate already running).

Also:
- Use %%PREFIX%% to let the ports provide a proper path for the binary.
- Do not specify htpdate_flags in command_args. htpdate_flags are already 
  passed to the program by rc.subr(8).

In response to this mailing list thread:
https://lists.freebsd.org/pipermail/freebsd-rc/2019-August/004047.html

[jgh]

In reviewing, I am running into issues in starting, although it does start.

> sudo service htpdate start
/usr/local/etc/rc.d/htpdate: ERROR: USAGE: check_process procname [interpreter]
Starting htpdate.

It does work, though, and removes most issues I've encountered.

[jgh]

I am trying to update the diff to what I have, based on changing some bits for rclint, and it isn't allowing me to, however here is the diff I do have:

Index: net/htpdate/Makefile
===================================================================
--- net/htpdate/Makefile	(revision 509979)
+++ net/htpdate/Makefile	(working copy)
@@ -3,6 +3,7 @@
 
 PORTNAME=	htpdate
 PORTVERSION=	1.2.2
+PORTREVISION=	1
 CATEGORIES=	net ipv6
 MASTER_SITES=	http://www.vervest.org/htp/archive/c/ \
 		http://twekkel.home.xs4all.nl/htp/
Index: net/htpdate/files/htpdate.in
===================================================================
--- net/htpdate/files/htpdate.in	(revision 509979)
+++ net/htpdate/files/htpdate.in	(working copy)
@@ -3,8 +3,7 @@
 # $FreeBSD$
 
 # PROVIDE: htpdate
-# REQUIRE: NETWORKING SERVERS
-# BEFORE: DAEMON
+# REQUIRE: NETWORKING syslogd
 # KEYWORD: shutdown
 
 # Add the following line to /etc/rc.conf to enable htpdate:
@@ -14,31 +13,27 @@
 
 . /etc/rc.subr
 
+name=htpdate
+desc="HTTP Time Protocol daemon"
+rcvar=htpdate_enable
+
 load_rc_config htpdate
 
-htpdate_enable="${htpdate_enable:-"NO"}"
-htpdate_servers="${htpdate_servers:-"www.example.com"}"
-htpdate_flags="${htpdate_flags:-"-l -s -D"}"
+: ${htpdate_enable:="NO"}
+: ${htpdate_servers:="www.example.com"}
+: ${htpdate_flags:="-l -s -D"}
 
-name=htpdate
-rcvar=htpdate_enable
-servers=${htpdate_servers}
-pidfile=/var/run/htpdate.pid
+start_precmd=htpdate_prestart
+command="%%PREFIX%%/bin/htpdate"
+command_args="${htpdate_servers}"
 
-command="/usr/local/bin/htpdate"
-command_args="${htpdate_flags} $servers"
-stop_cmd=htpdate_stop
+htpdate_prestart()
+{
+	local _pidfile="/var/run/htpdate.pid"
 
-htpdate_stop ()
-{
-	if [ -f ${pidfile} ]; then
-		echo "Stopping htpdate."
-		kill `cat ${pidfile}`
-	else
-		echo "htpdate is not running."
+	if [ -z "$(check_process "${procname}")" ]; then
+		rm -f -- "${_pidfile}"
 	fi
-
-	rm -f ${pidfile}
 }
 
 run_rc_command "$1"

[0mp]

• Use $command instead of $procname for check_process. It turns out that procname does not default to the value of command despite being documented to do so (I'll submit a patch shortly).
• Integrate jgh's changes.

[0mp]

Sorry for that bug. The change from command to procname was a last minute change before uploading the patch. Now the service starts and stops just fine for me.