Differential D21406

ping: use CMSG_FIRSTHDR() for accessing ancillary data
ClosedPublic
Actions

Authored by jansucan on Aug 24 2019, 4:31 PM.

Details

Reviewers

asomers

Commits

rS351461: ping: fix unaligned access to ancillary data

Summary

Use CMSG_FIRSTHDR() for accessing ancillary data

This should fix alignment error when built for sparc64 and powerpcspe.

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google LLC (Google Summer of Code 2019)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jansucan created this revision.Aug 24 2019, 4:31 PM

Harbormaster completed remote builds in B26079: Diff 61233.Aug 24 2019, 4:31 PM

jansucan mentioned this in D21405: ping: raise WARNS level to 6.Aug 24 2019, 4:36 PM

Well, it fixes the build. But now the program segfaults.

msg.msg_controllen must be initialized for CMSG_FIRSTHDR().

Harbormaster completed remote builds in B26082: Diff 61236.Aug 24 2019, 5:26 PM

asomers accepted this revision.Aug 24 2019, 5:57 PM

This revision is now accepted and ready to land.Aug 24 2019, 5:57 PM

Closed by commit rS351461: ping: fix unaligned access to ancillary data (authored by asomers). · Explain WhyAug 24 2019, 6:00 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS351461: ping: fix unaligned access to ancillary data.

Herald added a subscriber: imp. · View Herald TranscriptAug 24 2019, 6:00 PM

asomers mentioned this in rS352371: MFC r351318, r351330, r351393, r351398, r351440, r351461, r351548, r352226….Sep 16 2019, 12:57 AM

Revision Contents
Changeset List

Path

Size

head/

sbin/

ping/

ping.c

5 lines

Diff 61237

View Options

ping: use CMSG_FIRSTHDR() for accessing ancillary dataClosedPublicActions