Page MenuHomeFreeBSD
Differential D21262

If pkg-message is not a UCL file, assume the message is "install" only.
ClosedPublic
Actions

Authored by mat on Aug 14 2019, 12:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 13, 4:09 PM
Unknown Object (File)
Sun, Sep 13, 10:37 AM
Unknown Object (File)
Sun, Sep 13, 6:03 AM
Unknown Object (File)
Fri, Sep 11, 4:18 PM
Unknown Object (File)
Fri, Aug 28, 2:18 AM
Unknown Object (File)
Wed, Aug 26, 4:43 PM
Unknown Object (File)
Aug 11 2026, 11:58 PM
Unknown Object (File)
Aug 11 2026, 11:48 PM
View All Files
Subscribers
adamw

Details

Reviewers
None
Group Reviewers
portmgr
Commits
rP509282: Add a QA check warning porters about non UCL pkg-message files.
rP509281: If pkg-message is not a UCL file, assume the message is "install" only.
Summary

Add a QA check warning porters about non UCL pkg-message files.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mat created this revision.Aug 14 2019, 12:48 PM
Harbormaster completed remote builds in B25870: Diff 60780.Aug 14 2019, 12:48 PM
adamw added a subscriber: adamw.Aug 14 2019, 5:48 PM
adamw added inline comments.
Mk/Scripts/qa.sh
1002 ↗(On Diff #60780)

Maybe ${message} not in UCL format, will be shown on initial install only." would be clearer?
I don't know how long the string can be, but maybe add "See https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/pkg-files.html#porting-message" to help porters.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 19 2019, 12:18 PM
Closed by commit rP509281: If pkg-message is not a UCL file, assume the message is "install" only. (authored by mat). · Explain Why
This revision was automatically updated to reflect the committed changes.
mat added a commit: rP509281: If pkg-message is not a UCL file, assume the message is "install" only..
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptAug 19 2019, 12:18 PM
mat added a commit: rP509282: Add a QA check warning porters about non UCL pkg-message files..Aug 19 2019, 12:18 PM

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
Scripts/
2 linesO5: Ports Framework

Diff 60992

View Options

head/Mk/Scripts/create-manifest.sh

Loading...