Page MenuHomeFreeBSD

If pkg-message is not a UCL file, assume the message is "install" only.
ClosedPublic

Authored by mat on Aug 14 2019, 12:48 PM.

Details

Summary

Add a QA check warning porters about non UCL pkg-message files.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

adamw added inline comments.
Mk/Scripts/qa.sh
1002 ↗(On Diff #60780)

Maybe ${message} not in UCL format, will be shown on initial install only." would be clearer?
I don't know how long the string can be, but maybe add "See https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/pkg-files.html#porting-message" to help porters.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 19 2019, 12:18 PM
This revision was automatically updated to reflect the committed changes.