Mk/bsd.sanity.mk: Flag non-integer PORTREVISION / PORTEPOCH

[tobik]

Summary

Currently it is not checked and something like PORTREVISION=foo or just PORTREVISION= is accepted. Some ports use indirection via custom variables for them so I think it might be worthwhile to check them.

I am not sure if empty PORTREVISION/PORTEPOCH variables are deliberately supported or if this is just allowed as a byproduct of how make's != operator works.

Test Plan

Did a make -V DEV_ERROR sweep for this. The following ports failed this check:

devel/elfio		PORTREVISION empty
games/xboard		PORTEPOCH empty
games/xboard-devel	PORTEPOCH and PORTREVISON empty
misc/dnetc		custom variable that might be undefined
www/mod_dav_svn		custom variables based on devel/subversion version which might be unset
www/nuvolaplayer-*	slave port collection where PORTREVISION is based on custom variables that might be undefined
www/nuvolaplayer-8tracks
www/nuvolaplayer-amazon-cloud-player
www/nuvolaplayer-bandcamp
www/nuvolaplayer-google-play-music
www/nuvolaplayer-groove
www/nuvolaplayer-jango
www/nuvolaplayer-kexp
www/nuvolaplayer-logitech-media-server
www/nuvolaplayer-mixcloud
www/nuvolaplayer-plex
www/nuvolaplayer-soundcloud
www/nuvolaplayer-spotify
www/nuvolaplayer-tunein
www/nuvolaplayer-yandex-music
www/nuvolaplayer-youtube

[tobik]

• Fix games/xboard-devel PORTREVISON/PORTEPOCH

[mat]

devel/elfio/Makefile

6 ↗

(On Diff #60671)

In the other ports, you set it to 0, why remove it here?

[tobik]

devel/elfio/Makefile

6 ↗

(On Diff #60671)

The other ports are or have slave ports. This one is just a normal port.

[mat]

devel/elfio/Makefile

6 ↗

(On Diff #60671)

Well, the intent of the maintainer was to keep PORTREVISION in the Makefile, I would keep it with a value of 0.

[tobik]

devel/elfio/Makefile

6 ↗

(On Diff #60671)

Ok, makes sense.